Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge weechat-scripts version #20

Closed
wants to merge 1 commit into from

Conversation

stacyharper
Copy link

While backporting the eval expression to weechat-scripts:

weechat/scripts#555

I did notice that both version have diverged slightly.

This MR merge back it upstream here.

While backporting the eval expression to weechat-scripts:

weechat/scripts#555

I did notice that both version have diverged slightly.

This MR merge back it upstream here.
@stacyharper
Copy link
Author

I know that this merge make the release flags to be a bit wrong. But both now live in two different dystopics, so I don't really know what is the best thing to do.

@mumixam
Copy link
Owner

mumixam commented Jun 27, 2024

sorry the delay. is there any reason you changed the tag line
from
tags = dict([s.split('=',1) for s in mp['tags'].split(';')])
to
tags = dict([s.split('=') for s in mp['tags'].split(';')])

I'm not 100% sure why I did it like that in the 1st place honestly. codebase is pretty old at this point and I dont spend much time on twitch chat these days.

@stacyharper
Copy link
Author

iirc because this was causing warning or deprecated message in the weechat log buffer. But I'm not sure anymore

@mumixam
Copy link
Owner

mumixam commented Jun 29, 2024

I believe those are unrelated as i've never seen them myself. what version of python are you using

/debug libs
will tell you

Python 3.12.3 (main, Apr 23 2024, 09:16:07) [GCC 13.2.1 20240417] on linux
>>> 'T.e.s.t.i.n.g'.split('.',1)
['T', 'e.s.t.i.n.g']

@stacyharper
Copy link
Author

Okay, dunno where I saw this :S

@mumixam
Copy link
Owner

mumixam commented Jun 29, 2024

ok i found out the reason i added the maxsplit of 1.

this was to fix issues when the chat message contained "="

added in this commit
3c54a7b

@mumixam mumixam closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants