add support to set the ice version to support older ice versions #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. We can get forwards and backwards compatibility by sticking to encoding 1.0 like mumo already does (https://github.com/mumble-voip/mumo/blob/master/mumo.py#L144). We don't actually use/need any of the 1.1 features. Unfortunately that fix was never ported over to the authenticators from there (like quite a bit of other stuff like dynamic slice retrieval) :( Could you try hacst@f6e3f1e ? |
|
Yes, thank you, i will try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the problem that my system does not support ice version >1.0