Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of CMake, Python and pybind11 #53

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ilateur
Copy link
Collaborator

@ilateur ilateur commented Dec 3, 2024

  • Update CMake 3.16 to 3.31.1, with minimum of 3.24 for clean automatic CUDA architecture detection
  • Update Python from 3.8 to 3.13
  • Update pybind11 from ~v2.4 to v2.13.6
  • Set CMAKE_INTERPROCEDURAL_OPTIMIZATION to OFF to disable pybind::(thin_)lto
  • Fix mumax3 Slonczewski test after Python (NumPy) update

This changes both the conda environment and the pybind11 submodule. Please test out if everything works on your machines too before merging. After checking out this branch, update the conda environment with

conda env update --file environment.yml

and update pybind11 with

git submodule update

and install with pip install -ve ..
Afterwards (or maybe even before), git might keep bothering you about uncommitted pybind11 changes. You might need to go into the src/bindings/pybind11/ directory, run git status yourself and remove unwanted directories (like /tools/clang/) or undo unwanted changes. (A brand new user will not need to do this.)

- Update CMake 3.16 to 3.31.1, with minimum of 3.24 for clean automatic CUDA architecture detection
- Update Python from 3.8 to 3.13
- Update pybind11 from ~v2.4 to v2.13.6
- Set CMAKE_INTERPROCEDURAL_OPTIMIZATION to OFF to disable pybind::(thin_)lto
- Fix mumax3 Slonczewski test after Python (NumPy) update
@ilateur ilateur self-assigned this Dec 3, 2024
@DiegoDeGusem
Copy link
Contributor

It works 😄

@ilateur ilateur mentioned this pull request Dec 4, 2024
@ilateur ilateur linked an issue Dec 4, 2024 that may be closed by this pull request
@ilateur ilateur mentioned this pull request Jan 6, 2025
@ilateur
Copy link
Collaborator Author

ilateur commented Jan 15, 2025

I would like to merge this, but the main thing holding me back is that this is quite a substantial change, which makes branch switching more time consuming. I would like to decide together when this merge is most appropriate.

@ilateur
Copy link
Collaborator Author

ilateur commented Jan 24, 2025

After switching back and forth between versions, Pyvista did not work anymore for me. Completely reinstalling the conda environment fixes this.

conda deactivate
conda env remove -n mumaxplus
conda env create -f environment.yml
conda activate mumaxplus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python 3.8 is deprecated
2 participants