Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring src of sdk-core-wallet with history #490

Merged
merged 140 commits into from
Oct 2, 2024
Merged

Bring src of sdk-core-wallet with history #490

merged 140 commits into from
Oct 2, 2024
+2,069 −0

Conversation

danielailie
Copy link
Contributor

@danielailie danielailie commented Oct 2, 2024 •
edited
Loading

See #483.

Steps involved:

git clone [email protected]:multiversx/mx-sdk-js-core.git
git clone [email protected]:multiversx/mx-sdk-js-wallet.git

cd mx-sdk-js-wallet
git filter-repo --subdirectory-filter src --to-subdirectory-filter src-wallet --tag-rename 'src':'src-wallet'

cd ../mx-sdk-js-core

git checkout feat/unify
git checkout -b merge-wallet
git remote add wallet ../mx-sdk-js-wallet
git fetch wallet
git merge --allow-unrelated-histories wallet/main
git remote remove wallet
git push origin

How to review:

git clone -b merge-wallet [email protected]:multiversx/mx-sdk-js-core.git
git clone [email protected]:multiversx/mx-sdk-js-wallet.git
git diff --no-index mx-sdk-js-core/src-wallet mx-sdk-js-wallet/src

References:
https://stackoverflow.com/a/62096626/1475331

andreibancioiu and others added 30 commits December 3, 2020 15:21
@andreibancioiu
Sketch mnemonic class.
058e93a
@andreibancioiu
Sketch private key class.
4fe3533
@andreibancioiu
Compute public keys.
fe7e0ef
@andreibancioiu
WIP - Migrate toKeyFileObject.
4b7344d
@andreibancioiu
JSON keyfiles - generate and load. Tests.
c192bb4
@andreibancioiu
Bit of benchmarking for scryptsy.
7afc3b7
@andreibancioiu
Sketch BLS migration.
661d6a3
@andreibancioiu
Fix, test signing.
77d7244
@andreibancioiu
Rename files, re-group.
df33d2c
@andreibancioiu
PEM files. Signer components.
eb22b24
@andreibancioiu
Rename private -> secret.
70eb4a2
@andreibancioiu
Add tests, fix tests.
b48994b
@andreibancioiu
Fix after merge.
38c145a
@andreibancioiu
Fix after review, part 1.
676b984
@andreibancioiu
Fix after review, part 2.
6748803
@andreibancioiu
Merge branch 'development' into abi
1b7bd12
@andreibancioiu
Add test for signing using PEM file.
66760e4
@andreibancioiu
Extra checks, error handling and tests for PEM parsing etc.
a6478f8
@arhtudormorar
Make tweetnacl use Uint8Array
937001e
@andreibancioiu
Fixes necessary for automatic publishing of elrond-sdk-docs (#201)
f369b66 
* Sketch workflow to build docs.

* Fix typedoc configuration (upon upgrade to 0.20).

* Try out various options for grouping components (in docs).
@andreibancioiu
Merge branch 'development' into abi
0f4115e
@andreibancioiu
Fix some tests upon merge.
fc88864
@andreibancioiu
Fix after review.
2607ddc
@ccorcoveanu
implemented encryption component
e7344a6
@ccorcoveanu
implemented encryption component
702268d
@ccorcoveanu
add json decoed function for EncryptedData
77f3306
@claudiu725
Add contract wrapper
1145192
@ccorcoveanu
added empty line
1f93e0d
@ccorcoveanu
added empty line
a4b511e
@ccorcoveanu
typo fix
a0950fc
andreibancioiu and others added 24 commits May 24, 2023 13:43
@andreibancioiu
Add proper casts.
351abcb
@andreibancioiu
Merge pull request #40 from multiversx/uint8array-vs-buffer
45db24d 
Workaround: cast (convert) buffers to Uint8Array before calling noble functions
@popenta
add extra check
f46cc4c
@popenta
remove only
87eb57d
@popenta
add extra assert for unit test
cc4d2e6
@popenta
add new line
9e797c5
@popenta
make error more explicit
1366cf1
@popenta
Merge pull request #43 from multiversx/add-extra-check-decrypt-secret…
7470df5 
…-key

Added extra check when decrypting secret key
@andreibancioiu
Remove Axios as dev-dependency.
bc60489
@andreibancioiu
Merge pull request #44 from multiversx/dev-dependencies-2024-01-17
fe4d5f8 
Remove some dev-dependencies (axios, in particular)
@andreibancioiu
Accept "Uint8Array", in addition to "Buffer" on the main flows.
f27408d
@andreibancioiu
Merge pull request #47 from multiversx/next-core
dc50113 
Accept "Uint8Array", in addition to "Buffer" (on the main flows: sign, verify)
@andreibancioiu
Sketch support for custom HRP.
cac0eee
@andreibancioiu
Add "newFromBech32", in addition to the legacy "fromBech32".
3b4400e
@andreibancioiu
Undo some changes, add "internal" markers, add some tests.
ee264ef
@andreibancioiu
Deprecation notice.
01b9715
@andreibancioiu
Add library config.
26ee76a
@andreibancioiu
Merge pull request #48 from multiversx/custom-hrp
5794b87 
Add support for custom HRP
@andreibancioiu
Add mnemonicToEntropy and entropyToMnemonic.
5352a6d
@andreibancioiu
Handle some errors.
a5e0017
@andreibancioiu
Fix import.
2f74baa
@andreibancioiu
Fix imports.
4fb5e5c
@andreibancioiu
Merge pull request #52 from multiversx/entropy-1
74bb771 
Add "mnemonicToEntropy" and "entropyToMnemonic"
@danielailie
Merge remote-tracking branch 'wallet/main' into merge-wallet
8bc371c
@danielailie danielailie self-assigned this Oct 2, 2024
@andreibancioiu andreibancioiu changed the title Bring src of sdk-core-wallet with histori Bring src of sdk-core-wallet with history Oct 2, 2024
@danielailie danielailie merged commit de45867 into feat/unify Oct 2, 2024
3 of 4 checks passed
@danielailie danielailie deleted the merge-wallet branch October 2, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popenta popenta popenta approved these changes

@andreibancioiu andreibancioiu andreibancioiu approved these changes

Assignees

@danielailie danielailie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danielailie @andreibancioiu @popenta @arhtudormorar @ccorcoveanu @claudiu725 @claudiulataretu @radumojic @schimih