Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocation of
tx_hash_context.current_value
(bounded by MAX_VALUE_LEN):While
enc_len
is bounded by MAX_DISPLAY_DATA_SIZE:For STAX,
MAX_DISPLAY_DATA_SIZE = 256
, thusmemmove(encoded, tx_hash_context.current_value, enc_len);
fails to correctly copy the data (destination buffer is too short). This leads to an error when decoding it as base64 (within verify_data).For Nano S,
MAX_DISPLAY_DATA_SIZE = 64
, issue not present.Fix: ensure that
MAX_DISPLAY_DATA_SIZE <= MAX_VALUE_LEN
on all devices.