Relayed v3 support #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[auto] Update Screenshots
[auto] Update Screenshots
[auto] Update Screenshots
bogdan-rosianu
previously approved these changes
Jul 5, 2024
ssd04
reviewed
Jul 5, 2024
src/sign_tx_hash.c
Outdated
Comment on lines
31
to
32
| int ret_code = 0; | ||
| int err; |
There was a problem hiding this comment.
i think we can use here ret_code instead of adding err variable
tests/test_multiversx.py
Outdated
Comment on lines
458
to
459
| test_name) | ||
|
|
There was a problem hiding this comment.
add assert backend.last_async_response.status == Error.USER_DENIED ?
There was a problem hiding this comment.
done, well spotted
ssd04
previously approved these changes
Jul 12, 2024
ssd04
previously approved these changes
Jul 18, 2024
bogdan-rosianu
previously approved these changes
Jul 18, 2024
# Conflicts: # ledger_app.toml # tests/snapshots/nanosp/test_menu/00011.png # tests/snapshots/stax/test_get_addr_confirm_ok/00002.png # tests/snapshots/stax/test_get_addr_confirm_ok/00004.png # tests/snapshots/stax/test_menu/00001.png # tests/snapshots/stax/test_menu/00002.png # tests/snapshots/stax/test_menu/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_invalid_ttl/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_localhost_5min_ok/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_long_origin_should_trim_ok/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_long_ttl/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_ok/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_too_long_ttl_ok/00003.png # tests/snapshots/stax/test_sign_msg_auth_token_xexchange_24h_ok/00003.png # tests/snapshots/stax/test_sign_msg_long/00003.png # tests/snapshots/stax/test_sign_msg_short_ok/00009.png # tests/snapshots/stax/test_sign_tx_valid_esdt_with_guardian/00004.png # tests/snapshots/stax/test_sign_tx_valid_large_amount/00004.png # tests/snapshots/stax/test_sign_tx_valid_large_nonce/00004.png # tests/snapshots/stax/test_sign_tx_valid_large_receiver/00004.png # tests/snapshots/stax/test_sign_tx_valid_simple_no_data_confirmed/00004.png # tests/snapshots/stax/test_toggle_contract_data_0/00001.png # tests/snapshots/stax/test_toggle_contract_data_0/00002.png # tests/snapshots/stax/test_toggle_contract_data_0/00003.png # tests/snapshots/stax/test_toggle_contract_data_1/00001.png # tests/snapshots/stax/test_toggle_contract_data_1/00002.png # tests/snapshots/stax/test_toggle_contract_data_1/00003.png
Relayed v3 support app multiversx
AdoAdoAdo
dismissed stale reviews from bogdan-rosianu and ssd04
via
0960858
replaced deprecated functions
Adjust limits (for STAX)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.