add "merging own nodes to delegation sc" #734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| If the owner address of the node(s) and Delegation SC is the same use, whitelisting is not needed. | ||
| Send the following transaction : | ||
|
|
||
| ```rust |
There was a problem hiding this comment.
lines 56-61 can be removed since the information is duplicated. Please apply the same suggestion to the above section as well.
|
|
||
| ## **Merging own node(s)** | ||
|
|
||
| If the owner address of the node(s) and Delegation SC is the same use, whitelisting is not needed. |
There was a problem hiding this comment.
is the same use -> is the same
|
Added the proposed changes and fixed the suggested comments in #870 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the pull request (what is new / what has changed)
I've added a section explaining how to add your own nodes to your own delegation SC.
As I tried to do it myself, struggled and had to dig into old elrond docs.
Did you test the changes locally ?
Which category (categories) does this pull request belong to?