Proofs pool cleanup delta #6725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdoAdoAdo
reviewed
Jan 22, 2025
process/block/baseProcess.go
Outdated
| if bp.enableEpochsHandler.IsFlagEnabledInEpoch(common.EquivalentMessagesFlag, headerHandler.GetEpoch()) { | ||
| err := bp.dataPool.Proofs().CleanupProofsBehindNonce(bp.shardCoordinator.SelfId(), highestPrevFinalBlockNonce) | ||
| if common.ShouldBlockHavePrevProof(headerHandler, bp.enableEpochsHandler, common.EquivalentMessagesFlag) { | ||
| err := bp.dataPool.Proofs().CleanupProofsBehindNonce(bp.shardCoordinator.SelfId(), highestPrevFinalBlockNonce-proofsCleanupDelta) |
There was a problem hiding this comment.
make sure that highestPrevFinalBlockNonce-proofsCleanupDelta is not negative, otherwise it will cleanup everything (expected an unsigned 64)
I would compute the value first, and do the call only if >0
process/block/baseProcess.go
Outdated
| if bp.enableEpochsHandler.IsFlagEnabledInEpoch(common.EquivalentMessagesFlag, crossNotarizedHeader.GetEpoch()) { | ||
| err = bp.dataPool.Proofs().CleanupProofsBehindNonce(shardID, noncesToPrevFinal) | ||
| if common.ShouldBlockHavePrevProof(crossNotarizedHeader, bp.enableEpochsHandler, common.EquivalentMessagesFlag) { | ||
| err = bp.dataPool.Proofs().CleanupProofsBehindNonce(shardID, noncesToPrevFinal-proofsCleanupDelta) |
There was a problem hiding this comment.
same as my previous comment
cmd/node/config/config.toml
Outdated
| @@ -370,6 +370,9 @@ | |||
| MaxHeadersPerShard = 1000 | |||
| NumElementsToRemoveOnEviction = 200 | |||
|
|
|||
| [ProofsPoolConfig] | |||
| CleanupDelta = 3 | |||
There was a problem hiding this comment.
Suggested change
| CleanupDelta = 3 | |
| CleanupNonceDelta = 3 |
config/config.go
Outdated
| @@ -19,6 +19,11 @@ type HeadersPoolConfig struct { | |||
| NumElementsToRemoveOnEviction int | |||
| } | |||
|
|
|||
| // ProofsPoolConfig will map the proofs cache configuration | |||
| type ProofsPoolConfig struct { | |||
| CleanupDelta uint64 | |||
There was a problem hiding this comment.
Suggested change
| CleanupDelta uint64 | |
| CleanupNonceDelta uint64 |
| func NewProofsPool() *proofsPool { | ||
| func NewProofsPool(cleanupDelta uint64) *proofsPool { | ||
| if cleanupDelta < defaultCleanupDelta { | ||
| cleanupDelta = defaultCleanupDelta |
There was a problem hiding this comment.
maybe a log.Debug informing this?
sstanculeanu
approved these changes
Jan 22, 2025
AdoAdoAdo
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?