Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DestinationShardAsObserver default "0" #6715

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

axenteoctavian
Copy link
Contributor

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@axenteoctavian axenteoctavian self-assigned this Jan 20, 2025
liviuf-ancas
liviuf-ancas previously approved these changes Jan 20, 2025
mariusmihaic
mariusmihaic previously approved these changes Jan 21, 2025
@@ -2,7 +2,7 @@
# DestinationShardAsObserver represents the desired shard when running as observer
# value will be given as string. For example: "0", "1", "15", "metachain"
# if "disabled" is provided then the node will start in the corresponding shard for its public key or 0 otherwise
DestinationShardAsObserver = "disabled"
DestinationShardAsObserver = "0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change the comment above regarding meta/disabled and mention that the only correct value is '0'

@axenteoctavian axenteoctavian merged commit b6038d1 into feat/chain-go-sdk Jan 21, 2025
6 checks passed
@axenteoctavian axenteoctavian deleted the observer-shard-prefs-toml branch January 21, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants