Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple smart contract results with refund #6709

Open
wants to merge 4 commits into
base: feat/relayedv3
Choose a base branch
from

Conversation

miiu96
Copy link
Contributor

@miiu96 miiu96 commented Jan 15, 2025

Reasoning behind the pull request

  • Implemented the part compute fee and gas used in case of multiple smart contract results with refund value

Proposed changes

Testing procedure

  • Ensure gas used and the fee is calculated correctly

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@@ -326,11 +331,19 @@ func (tep *transactionsFeeProcessor) prepareScrsNoTx(transactionsAndScrs *transa

userTx := tep.getUserTxOfRelayed(txFromStorage)
if check.IfNil(userTx) {
// relayed v3 and other txs
if isRelayedV3 {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we have a regular tx that generates multiple refunds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants