Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count all refunds if more than one scr exists #6708

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

  • if more than one refund scrs are generated for a tx, only one is considered while computing the fee field on node api

Proposed changes

  • take into account all refund scrs for node api

Testing procedure

  • with feat branch, send a tx that generate multiple refunds

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu added type:bug Something isn't working area:node-api Node API ignore-for-release-notes Do not include item in release notes labels Jan 15, 2025
@sstanculeanu sstanculeanu self-assigned this Jan 15, 2025
@sstanculeanu sstanculeanu merged commit 9caaba2 into feat/relayedv3 Jan 15, 2025
5 checks passed
@sstanculeanu sstanculeanu deleted the node_api_fix_multiple_refunds branch January 15, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:node-api Node API ignore-for-release-notes Do not include item in release notes type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants