Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/relayedv3 #6632

Open
wants to merge 65 commits into
base: rc/spica-patch-relayedv3
Choose a base branch
from
Open

Feat/relayedv3 #6632

wants to merge 65 commits into from

Conversation

sstanculeanu
Copy link
Collaborator

@sstanculeanu sstanculeanu commented Nov 25, 2024

Reasoning behind the pull request

  • new relayed tx v3 implementation proposed, which should work exactly as a regular transaction but fees are paid by a relayer, which should be included on a new field of the transaction

Proposed changes

  • implement relayed v3 that now holds relayerAddr and relayerSignature as new fields
  • process transaction as a regular tx, but consume fees from the relayer
  • this tx requires an extra 50.000 gas for the relayed operation

Testing procedure

  • standard system test + relayed txs scenarios

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@sstanculeanu sstanculeanu self-assigned this Nov 25, 2024
@sstanculeanu sstanculeanu changed the base branch from rc/spica-patch-mempool to rc/spica-patch-relayedv3 November 28, 2024 15:31
@multiversx multiversx deleted a comment from github-actions bot Jan 13, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 13, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 13, 2025
Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@sstanculeanu
Copy link
Collaborator Author

sstanculeanu commented Jan 14, 2025

Run Tests:
mx-chain-testing-suite: rc/barnard
mx-chain-simulator-go: relayedv3

@multiversx multiversx deleted a comment from github-actions bot Jan 14, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 14, 2025
@multiversx multiversx deleted a comment from github-actions bot Jan 14, 2025
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 545d15eccea4cc4e504c75a5833f764311b8e323
  • Current Branch: feat/relayedv3
  • mx-chain-go Target Branch: rc/spica-patch-relayedv3
  • mx-chain-simulator-go Target Branch: relayedv3
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 14012025-154333
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

Copy link
Collaborator

@danidrasovean danidrasovean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal allin test: v1.8.6-dev-config -> feat/relayedv3

--- Specific errors ---

block hash does not match 377
wrong nonce in block 268
miniblocks does not match 0
num miniblocks does not match 0
miniblock hash does not match 0
block bodies does not match 0
receipts hash missmatch 0

/------/

--- Statistics ---

Nr. of all ERRORS: 0
Nr. of all WARNS: 331
Nr. of new ERRORS: 0
Nr. of new WARNS: 23
Nr. of PANICS: 0
Nodes with panic: []

/------/

--- System test go ---

All scenarios from system-test-go are OK!

/------/

--- ERRORS ---

/------/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants