Mx 15702 sovereign enable epochs handler #6626

axenteoctavian · 2024-11-22T15:41:17Z

Reasoning behind the pull request

need sovereign enable epochs handler

Proposed changes

enable epochs handler in run type core components

Testing procedure

sovereign chain simulator tests passed

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

was the PR targeted to the correct branch?
if this is a larger feature that probably needs more than one PR, is there a feat branch created?
if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

This reverts commit 616fb58.

…nable-epochs-handler

…s-handler

…-handler' into MX-15702-sovereign-enable-epochs-handler

…s-handler # Conflicts: # genesis/process/sovereignGenesisBlockCreator.go

common/enablers/errors.go

common/enablers/sovereignEnableEpochsHandler.go

config/epochConfig.go

factory/runType/sovereignRunTypeCoreComponents.go

genesis/process/genesisBlockCreator.go

integrationTests/realcomponents/processorRunner.go

integrationTests/testProcessorNode.go

node/chainSimulator/components/coreComponents.go

…s-handler # Conflicts: # factory/processing/processComponents.go # factory/processing/processComponents_test.go

factory/core/coreComponents_test.go

factory/core/coreComponents.go

cmd/sovereignnode/main.go

cmd/sovereignnode/config/common.go

…s-handler

codecov · 2024-12-11T14:51:55Z

Codecov Report

Attention: Patch coverage is 86.33094% with 19 lines in your changes missing coverage. Please review.

Project coverage is 77.69%. Comparing base (000cff6) to head (2c0776e).
Report is 1235 commits behind head on feat/chain-go-sdk.

Files with missing lines	Patch %	Lines
node/nodeRunner.go	0.00%	13 Missing ⚠️
factory/runType/runTypeCoreComponentsHandler.go	75.00%	1 Missing and 1 partial ⚠️
genesis/process/genesisBlockCreator.go	33.33%	1 Missing and 1 partial ⚠️
...ode/chainSimulator/components/processComponents.go	0.00%	1 Missing ⚠️
...hainSimulator/components/testOnlyProcessingNode.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                  @@
##           feat/chain-go-sdk    #6626      +/-   ##
=====================================================
+ Coverage              77.68%   77.69%   +0.01%     
=====================================================
  Files                    928      963      +35     
  Lines                 106315   108696    +2381     
=====================================================
+ Hits                   82593    84456    +1863     
- Misses                 18035    18416     +381     
- Partials                5687     5824     +137

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…s-handler # Conflicts: # factory/processing/processComponents.go # genesis/process/genesisBlockCreator.go # integrationTests/realcomponents/processorRunner.go # node/nodeRunner.go

mariusmihaic · 2025-01-14T10:20:32Z

cmd/sovereignnode/config/enableEpochs.toml

@@ -92,7 +92,7 @@
    ValidatorToDelegationEnableEpoch = 0

    # WaitingListFixEnableEpoch represents the epoch when the 6 epoch waiting list fix is enabled
-    WaitingListFixEnableEpoch = 1000000
+    WaitingListFixEnableEpoch = 0


This flag I think should always be disabled or never used.

I think in the original enableEpochs.toml from node this flag should have been deleted.
Also, not sure about CorrectLastUnjailedEnableEpoch & BuiltInFunctionOnMetaEnableEpoch. We should ask @sasurobert 's opinion as well

Delete this epoch. That fix was never implemented and we do not have waiting list anymore.
CorrectLastUnJailed can be deleted from here, as it is treated as 0 in that case, same with builtInFuncOnMeta.

Deleted WaitingListFixEnableEpoch and BuiltInFunctionOnMetaEnableEpoch.

I kept the CorrectLastUnjailedEnableEpoch because is a flag in enable epochs handler

config/tomlConfig_test.go

sasurobert · 2025-01-20T08:41:40Z

cmd/sovereignnode/chainSimulator/sovereignChainSimulator_test.go

@@ -4,13 +4,13 @@ import (
 	"testing"
 	"time"

+	"github.com/multiversx/mx-chain-core-go/core"
+	"github.com/stretchr/testify/require"


This seems to be ok, it's split in 3 categories.

sasurobert · 2025-01-20T08:44:18Z

cmd/sovereignnode/main.go

@@ -8,14 +8,15 @@ import (

 	"github.com/multiversx/mx-chain-core-go/core"
 	"github.com/multiversx/mx-chain-core-go/core/check"
+	logger "github.com/multiversx/mx-chain-logger-go"
+	"github.com/multiversx/mx-chain-logger-go/file"
+	"github.com/urfave/cli"


This seems to be ok, it's split in 3 categories.

sasurobert · 2025-01-20T08:52:04Z

factory/core/coreComponents_test.go

@@ -4,12 +4,17 @@ import (
 	"errors"
 	"testing"

+	"github.com/stretchr/testify/require"


goimports everywhere.

This seems to be ok, it's split in 3 categories.

…s-handler

axenteoctavian added 2 commits November 22, 2024 16:58

sovereign enable epochs handler components

06ec481

enable epoch handler in run type core components

616fb58

axenteoctavian self-assigned this Nov 22, 2024

axenteoctavian and others added 18 commits November 22, 2024 18:25

Revert "enable epoch handler in run type core components"

cdf3af3

This reverts commit 616fb58.

Merge branch 'refs/heads/feat/chain-go-sdk' into MX-15702-sovereign-e…

25e723d

…nable-epochs-handler

sovereign enable epoch handler in components

1ecbf3a

fixes and unit test files

39dd138

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

ae8c842

…s-handler

mocks and other changes

24f419a

unit test fixes

a0726b2

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

dfd199d

…s-handler

fixes after running long tests

35b4a1b

Merge remote-tracking branch 'origin/MX-15702-sovereign-enable-epochs…

2987d1d

…-handler' into MX-15702-sovereign-enable-epochs-handler

fixes after running long tests

8277d45

unit test fix

08aaac2

fixes after self review

392e646

fixes after self review

3ecac02

fixes after self review

5c8327f

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

246363d

…s-handler # Conflicts: # genesis/process/sovereignGenesisBlockCreator.go

fix sovereign genesis block creator

7a8922f

nodes setup mock updated

368e17a

axenteoctavian marked this pull request as ready for review November 28, 2024 14:56

mariusmihaic self-requested a review December 4, 2024 11:36

mariusmihaic requested changes Dec 6, 2024

View reviewed changes

axenteoctavian added 4 commits December 6, 2024 15:26

refactor the implementation

caba123

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

5f9042c

…s-handler # Conflicts: # factory/processing/processComponents.go # factory/processing/processComponents_test.go

fixes after review

b8fd2f8

fixes after review

bcbce0e

mariusmihaic requested changes Dec 11, 2024

View reviewed changes

factory/core/coreComponents_test.go Show resolved Hide resolved

factory/core/coreComponents.go Show resolved Hide resolved

cmd/sovereignnode/main.go Show resolved Hide resolved

cmd/sovereignnode/config/common.go Show resolved Hide resolved

added missing checks

739d48e

axenteoctavian and others added 4 commits December 11, 2024 15:44

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

d2aac11

…s-handler

extra comment

2cc653b

all flags with epoch 0

4a767eb

sovereign epoch config unit test

2c0776e

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

f5dc173

…s-handler # Conflicts: # factory/processing/processComponents.go # genesis/process/genesisBlockCreator.go # integrationTests/realcomponents/processorRunner.go # node/nodeRunner.go

multiversx deleted a comment from github-actions bot Dec 13, 2024

fix testing component

a3798d0

mariusmihaic reviewed Jan 14, 2025

View reviewed changes

fix after review

d7c0065

sasurobert self-requested a review January 20, 2025 08:27

sasurobert reviewed Jan 20, 2025

View reviewed changes

fixes after review

a0518b0

mariusmihaic approved these changes Jan 20, 2025

View reviewed changes

Merge branch 'feat/chain-go-sdk' into MX-15702-sovereign-enable-epoch…

9763762

…s-handler

sasurobert approved these changes Jan 21, 2025

View reviewed changes

axenteoctavian merged commit 2c00d8a into feat/chain-go-sdk Jan 21, 2025
6 checks passed

axenteoctavian deleted the MX-15702-sovereign-enable-epochs-handler branch January 21, 2025 10:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mx 15702 sovereign enable epochs handler #6626

Mx 15702 sovereign enable epochs handler #6626

axenteoctavian commented Nov 22, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024

mariusmihaic Jan 14, 2025

sasurobert Jan 20, 2025

axenteoctavian Jan 20, 2025

sasurobert Jan 20, 2025

axenteoctavian Jan 20, 2025

sasurobert Jan 20, 2025

axenteoctavian Jan 20, 2025

sasurobert Jan 20, 2025

axenteoctavian Jan 20, 2025

Mx 15702 sovereign enable epochs handler #6626

Mx 15702 sovereign enable epochs handler #6626

Conversation

axenteoctavian commented Nov 22, 2024 • edited Loading

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

codecov bot commented Dec 11, 2024

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

axenteoctavian commented Nov 22, 2024 •

edited

Loading