-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sovereign] Bugfix notifier bootstrapper + cleanup notarized headers #6622
Merged
mariusmihaic
merged 6 commits into
feat/sovereign-mainchain-header-sync
from
MX-16147-fix-sync-process-block-block-finality
Nov 25, 2024
Merged
[sovereign] Bugfix notifier bootstrapper + cleanup notarized headers #6622
mariusmihaic
merged 6 commits into
feat/sovereign-mainchain-header-sync
from
MX-16147-fix-sync-process-block-block-finality
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusmihaic
changed the title
[sovereign] Fix synced block for isHeaderReceivedTooLate by setting blockFinality to 0
[sovereign] Bugfix notifier bootstrapper + cleanup notarized headers
Nov 21, 2024
Comment on lines
147
to
148
} else if round == 2 { // first cross notarized header is 10000000 | ||
require.Equal(t, headerNonce, crossNotarizedHeader.GetNonce()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
} else if round == 2 { // first cross notarized header is 10000000 | |
require.Equal(t, headerNonce, crossNotarizedHeader.GetNonce()) |
sasurobert
approved these changes
Nov 25, 2024
sasurobert
previously approved these changes
Nov 25, 2024
axenteoctavian
approved these changes
Nov 25, 2024
sasurobert
approved these changes
Nov 25, 2024
mariusmihaic
merged commit Nov 25, 2024
624ae44
into
feat/sovereign-mainchain-header-sync
4 checks passed
mariusmihaic
deleted the
MX-16147-fix-sync-process-block-block-finality
branch
November 25, 2024 09:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
feat
branch created?feat
branch merging, do all satellite projects have a proper tag insidego.mod
?