Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sovereign] Bugfix notifier bootstrapper + cleanup notarized headers #6622

Conversation

mariusmihaic
Copy link
Contributor

@mariusmihaic mariusmihaic commented Nov 19, 2024

Reasoning behind the pull request

  • Several bugs

Proposed changes

  • Fixed notifier bootstrapper to use a confidence threshold for synced times before subscribing to receive data. This is because the sync mechanism can sometimes send "false positives"
  • Fixed cleanup of notarized headers for cross shard. There was a very tricky bug, which would delete notarized mainchain headers instead of self chain headers

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@mariusmihaic mariusmihaic self-assigned this Nov 19, 2024
@mariusmihaic mariusmihaic marked this pull request as ready for review November 21, 2024 13:02
@mariusmihaic mariusmihaic changed the title [sovereign] Fix synced block for isHeaderReceivedTooLate by setting blockFinality to 0 [sovereign] Bugfix notifier bootstrapper + cleanup notarized headers Nov 21, 2024
@axenteoctavian axenteoctavian self-requested a review November 22, 2024 08:24
Comment on lines 147 to 148
} else if round == 2 { // first cross notarized header is 10000000
require.Equal(t, headerNonce, crossNotarizedHeader.GetNonce())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
} else if round == 2 { // first cross notarized header is 10000000
require.Equal(t, headerNonce, crossNotarizedHeader.GetNonce())

sasurobert
sasurobert previously approved these changes Nov 25, 2024
@mariusmihaic mariusmihaic merged commit 624ae44 into feat/sovereign-mainchain-header-sync Nov 25, 2024
4 checks passed
@mariusmihaic mariusmihaic deleted the MX-16147-fix-sync-process-block-block-finality branch November 25, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants