Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rc/spica-patch-mempool #6613

Merged
merged 172 commits into from
Dec 9, 2024
Merged

rc/spica-patch-mempool #6613

merged 172 commits into from
Dec 9, 2024

Conversation

sstanculeanu
Copy link
Collaborator

Reasoning behind the pull request

Proposed changes

Testing procedure

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

andreibancioiu and others added 30 commits July 10, 2024 00:10
@andreibancioiu
Reference newer storage-go.
859fd8d
@andreibancioiu
Fix tests.
10c67f1
@andreibancioiu
Newer storage-go.
fd214d6
@andreibancioiu
Adjust NumTxPerSenderBatchForFillingMiniblock, MaxGasBandwidthPerBatc…
8f92b0c 
…hPerSender.
@andreibancioiu
Update go.mod.
3ea4345
@andreibancioiu
Fix tests.
3b2f40e
@andreibancioiu
Integrate new selection parameter.
1202873
@andreibancioiu
Adjust / skip test.
fea4455
@andreibancioiu
Some TODOs, update reference of storage-go.
61efec0
@andreibancioiu
Optimize shardedTxPool.removeTxBulk.
81e742a
@andreibancioiu
Testing workaround - notify account nonce when adding tx in pool.
6e7d92d
@andreibancioiu
Update reference.
17aa534
@andreibancioiu
Extra check on workaround for testing.
618f2f0
@andreibancioiu
Pass epoch notifier to sharded TX pool.
04a2764
@cristure
calculate hash only on log trace level set.
6841919
@cristure
add non-memory thrasher test.
85d93ac
@andreibancioiu
Minor refactoring / cleanup.
3a2a25a
@andreibancioiu
Define account nonce provider. Pass epoch notifier and account nonce …
20f174f 
…provider to sharded tx pool.
@andreibancioiu
Fix some tests.
652d417
@andreibancioiu
In sharded tx pool, on tx add, notify cache about sender nonce.
9063904
@andreibancioiu
Fix additional tests.
c8f4d6d
@andreibancioiu
Fix short test.
f126716
@andreibancioiu
Fix linter.
8a4f344
@andreibancioiu
Fix long tests (return err in nonce provider).
416ad59
@andreibancioiu
Adjust log, tests. Plus minor refactoring.
25cd44f
@andreibancioiu
Merge branch 'master' into master-into-mempool-2024-09-08
8bde909
@andreibancioiu
Merge branch 'master' into mempool-10
ce579e3
@andreibancioiu
Merge pull request #6381 from multiversx/master-into-mempool-2024-09-08
c48f5d2 
Master into feat/mempool
@andreibancioiu
Add TODO.
665c53c
@andreibancioiu
Merge branch 'master' into mempool-10
2d641f5
andreibancioiu and others added 18 commits November 29, 2024 15:40
@andreibancioiu
Implement an ephemeral accounts cache within a selection session.
8185866
@andreibancioiu
Merge pull request #6641 from multiversx/MX-16211-optimize-get-value
d556eb8 
Mempool optimization: on transaction addition, call "GetTransferredValue" and retain its value
@andreibancioiu
Merge branch 'feat/mempool' into MX-16223-mempool-memoization
9b1afba
@andreibancioiu
Reference newer storage-go.
91c17ad
@andreibancioiu
Merge branch 'MX-16223-mempool-memoization' of ssh://github.com/multi…
ffaeb85 
…versx/mx-chain-go into MX-16223-mempool-memoization
@andreibancioiu
Add unit test, fix after review (references to storage-go).
389c78b
@andreibancioiu
Merge pull request #6643 from multiversx/MX-16223-mempool-memoization
a7c336e 
Implement an ephemeral accounts cache within a selection session
@andreibancioiu
Adjust TxDataPool.SizePerSender.
881d8f5
@andreibancioiu
Merge pull request #6644 from multiversx/MX-16202-sender-constraints
8bce7d1 
Mempool: adjust sender constraints
@andreibancioiu
Optimization: lower "maxNum" when selecting transactions.
d75b3eb
@andreibancioiu
Reference storage-go.
801c199
@andreibancioiu
Merge pull request #6645 from multiversx/MX-16207-selection-max-num
11fc7c6 
Mempool: lower "maxNum" when selecting transactions
@ssd04
change to fetch tokens by NonFungibleESDTv2 type
8a9b204
@ssd04
add custom handling for getting non fungible tokens
58179fa
@ssd04
handle also dynamic nft and sft
cfa9338
@ssd04
Merge branch 'rc/spica-patch-mempool' into fix-api-nfts-tokens-type
4b2d82e
@andreibancioiu
Merge pull request #6640 from multiversx/feat/mempool
7c4667b 
Mempool improvements
@andreibancioiu
Merge branch 'rc/spica-patch-mempool' into fix-api-nfts-tokens-type
04fd98d
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 7c4667b1a8c94ca254b56ff1e860ea4aff865d7e
  • Current Branch: rc/spica-patch-mempool
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-102629
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

@andreibancioiu andreibancioiu marked this pull request as ready for review December 5, 2024 10:45
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e65a3d42addd57c5e4264489f3b8e5c30bb3c902
  • Current Branch: rc/spica-patch-mempool
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-110056
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 861b336a4fb9061d43e0806f2e2444f9b87dc365
  • Current Branch: rc/spica-patch-mempool
  • mx-chain-go Target Branch: master
  • mx-chain-simulator-go Target Branch: main
  • mx-chain-testing-suite Target Branch: main

🚀 Environment Variables:

  • TIMESTAMP: 05122024-114503
  • PYTEST_EXIT_CODE: 0
    🎉 MultiversX CI/CD Workflow Complete!

@sstanculeanu sstanculeanu merged commit 54bce4b into master Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danidrasovean danidrasovean danidrasovean approved these changes

@ssd04 ssd04 ssd04 approved these changes

@andreibancioiu andreibancioiu andreibancioiu approved these changes

Assignees

@sstanculeanu sstanculeanu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sstanculeanu @andreibancioiu @ssd04 @danidrasovean @cristure @AdoAdoAdo