Feat/esdt prefix #6137
Open
Feat/esdt prefix #6137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| checkTickerAndNonceExtraction(t, "pref-ALC-1q2w3e", "pref-ALC-1q2w3e", 0) | ||
| checkTickerAndNonceExtraction(t, "pf1-ALC-1q2w3e", "pf1-ALC-1q2w3e", 0) | ||
|
|
||
| checkTickerAndNonceExtraction(t, "sv1-TKN-1q2w3e4", "sv1-TKN-1q2w3e", 52) |
There was a problem hiding this comment.
We also need tests with min/max characters for prefix and min/max characters for ticker, and combination of these.
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Esdt safe callback test on fail case
…7-nov # Conflicts: # errors/errors.go
…prefix-7-nov Merge rc 1 7 next into esdt prefix 7 nov
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
…n-go into relayedv3 # Conflicts: # go.mod # go.sum
…executing scheduled miniblocks.
…actor Refactor register functions to be usable in sovereign chain simulator
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
fixed the computed fee for outport for relayed v3
fix chain simulator
count all refunds if more than one scr exists
…multiple-scrs-with-refund
…ientBalanceForFee_WithRelayedV3.
…eZeroBalance_WithRelayedV3.
Multiple smart contract results with refund
…ultiversx/mx-chain-go into MX-16207-mempool-chain-simulator
…ator Mempool: bit of refactoring, chain simulator tests
updated deps
Feat/relayedv3
…dexer Fix indexer
…erge-spica-relayed-into-esdt-prefix-31-ian # Conflicts: # go.mod # go.sum
…t-prefix-31-ian Merge spica relayed into esdt prefix 31 ian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
This branch includes several cross chain features needed for main chain(mainnet/devnet/testnet/local-testnet) -> sovereign chain communication:
More specifically, let's consider a mainnet scenario, where this deposit safe contract is deployed (therefore, all issued esdts will have no prefix). Now, if we want to mint extra esdts/nfts/sfts, this won't be possible, only through our whitelisted address. Our use case is that a user will call an endpoint
depositfrom this sc, which will contain several information including tokenID and amount to deposit to a specific address. This contract shall be allowed to mint required token amount(with the same tokenID and prefix) and send them to destination.Same scenario should work for a sovereign chain(where the config specifies that the chain will issue tokens with a specific
ESDTPrefix) and where we will deposit unprefixed tokens.Another interesting use case is for cross chain sfts/nfts(basically a token with meta data and nonce). For those specific bridged in(from sov->main) tokens, a different type of input for builtInFunc from
esdtNFTCreatewill be created and executed. More specifically, for cross chain operations, last two arguments should be(these are added from inside the whitelisted address, if not, tx should fail):Also, use cases with "proxy" contracts (e.g.: user calls -> contract A -> calls ESDTSafe(whitelisted) contract) should work only for whitelisted addresses and meta data should be correctly filled.
The same bridged in meta data (from sov->main) should be found in the contract emitted log when bridged out (main->sov) .
This is the list with all whitelisted cross actions that should be tested:
Proposed changes
-separator)cmd/node/config/systemSmartContractsConfig.toml:Whitelisted addresses can be found in
cmd/node/config/config.tomlTesting procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?