Feat 3.5 implementation #196

dragos-rebegea · 2024-08-22T08:14:39Z

No description provided.

common transaction

add sc event with data field

update and create public endpoints that will call create_transaction_common

github-actions · 2024-08-22T08:15:27Z

Coverage Summary

Totals

	Count	Covered	%
Lines	6600	4852	73.52
Regions	1268	808	63.72
Functions	617	407	65.96
Instantiations	4621	1170	25.32

Files

Expand

File	Lines	Regions	Functions	Instantiations
/home/runner/.cargo/git/checkouts/mx-contracts-rs-13011bd47afef959/d91bbff/contracts/crowdfunding-esdt/src/crowdfunding_esdt.rs	51.56%	57.14%	77.78%	64.00%
/home/runner/.cargo/git/checkouts/mx-contracts-rs-13011bd47afef959/d91bbff/contracts/crowdfunding-esdt/src/crowdfunding_esdt_proxy.rs	100.00%	100.00%	100.00%	100.00%
/bridge-proxy/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/bridge-proxy/src/bridge-proxy.rs	54.17%	59.57%	60.00%	21.56%
/bridge-proxy/src/bridge_proxy_contract_proxy.rs	100.00%	100.00%	100.00%	66.67%
/bridge-proxy/src/bridged_tokens_wrapper.rs	0.00%	0.00%	0.00%	0.00%
/bridge-proxy/src/bridged_tokens_wrapper_proxy.rs	88.73%	85.71%	85.71%	46.15%
/bridge-proxy/src/config.rs	89.47%	72.73%	100.00%	26.04%
/bridge-proxy/tests/bridge_proxy_blackbox_test.rs	96.43%	88.89%	88.89%	88.89%
/bridged-tokens-wrapper/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/bridged-tokens-wrapper/src/dfp_big_uint.rs	100.00%	100.00%	100.00%	20.00%
/bridged-tokens-wrapper/src/esdt_safe_proxy.rs	0.00%	0.00%	0.00%	0.00%
/bridged-tokens-wrapper/src/events.rs	0.00%	0.00%	0.00%	0.00%
/bridged-tokens-wrapper/src/lib.rs	33.16%	44.90%	45.00%	12.59%
/bridged-tokens-wrapper/tests/dfp_big_uint_test.rs	100.00%	100.00%	100.00%	100.00%
/bridged-tokens-wrapper/tests/scenario_go_test.rs	100.00%	100.00%	100.00%	100.00%
/common/eth-address/src/lib.rs	93.33%	66.67%	88.89%	46.74%
/common/fee-estimator-module/src/lib.rs	95.12%	87.50%	90.00%	19.14%
/common/fee-estimator-module/src/price_aggregator_proxy.rs	6.14%	4.76%	6.67%	5.13%
/common/max-bridged-amount-module/src/lib.rs	100.00%	87.50%	100.00%	16.96%
/common/token-module/src/lib.rs	79.86%	73.91%	80.00%	22.67%
/common/transaction/src/lib.rs	47.17%	49.02%	62.50%	29.47%
/common/transaction/src/transaction_status.rs	83.33%	66.67%	83.33%	37.74%
/common/tx-batch-module/src/batch_status.rs	66.67%	50.00%	66.67%	18.75%
/common/tx-batch-module/src/lib.rs	88.07%	80.82%	87.50%	20.23%
/common/tx-batch-module/src/tx_batch_mapper.rs	92.54%	89.66%	100.00%	36.67%
/esdt-safe/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/esdt-safe/src/esdt_safe_proxy.rs	100.00%	100.00%	100.00%	55.56%
/esdt-safe/src/lib.rs	82.39%	71.55%	85.19%	23.61%
/esdt-safe/tests/esdt_safe_blackbox_test.rs	98.99%	84.62%	100.00%	100.00%
/esdt-safe/tests/esdt_safe_scenario_rs_test.rs	100.00%	100.00%	100.00%	100.00%
/esdt-safe/tests/scenario_go_test.rs	100.00%	100.00%	100.00%	100.00%
/multi-transfer-esdt/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/multi-transfer-esdt/src/bridge_proxy_contract_proxy.rs	53.85%	66.67%	66.67%	36.36%
/multi-transfer-esdt/src/bridged_tokens_wrapper_proxy.rs	100.00%	100.00%	100.00%	60.00%
/multi-transfer-esdt/src/esdt_safe_proxy.rs	100.00%	100.00%	100.00%	47.62%
/multi-transfer-esdt/src/esdt_safe_proxy_test_only.rs	54.55%	66.67%	66.67%	40.00%
/multi-transfer-esdt/src/lib.rs	66.67%	67.31%	76.92%	28.43%
/multi-transfer-esdt/src/multi_transfer_esdt_proxy.rs	100.00%	100.00%	100.00%	55.56%
/multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs	99.77%	95.00%	100.00%	100.00%
/multi-transfer-esdt/tests/multi_transfer_esdt_scenario_rs_test.rs	57.14%	30.00%	30.00%	30.00%
/multi-transfer-esdt/tests/scenario_go_test.rs	30.00%	30.00%	30.00%	30.00%
/multisig/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/multisig/src/action.rs	25.00%	22.22%	33.33%	30.77%
/multisig/src/bridge_proxy_contract_proxy.rs	0.00%	0.00%	0.00%	0.00%
/multisig/src/esdt_safe_proxy.rs	55.25%	55.00%	55.00%	19.67%
/multisig/src/events.rs	100.00%	66.67%	100.00%	14.29%
/multisig/src/lib.rs	77.78%	75.00%	87.50%	32.50%
/multisig/src/multi_transfer_esdt_proxy.rs	66.67%	72.73%	72.73%	28.57%
/multisig/src/multisig_general.rs	80.00%	65.38%	75.00%	30.77%
/multisig/src/multisig_proxy.rs	77.09%	34.29%	54.55%	36.84%
/multisig/src/queries.rs	64.52%	61.76%	57.89%	15.79%
/multisig/src/setup.rs	28.03%	34.09%	27.59%	7.49%
/multisig/src/storage.rs	100.00%	66.67%	100.00%	27.41%
/multisig/src/user_role.rs	83.33%	72.73%	75.00%	41.67%
/multisig/src/util.rs	94.44%	84.38%	100.00%	44.12%
/multisig/tests/multisig_blackbox_test.rs	100.00%	100.00%	100.00%	100.00%
/multisig/tests/multisig_scenario_rs_test.rs	82.69%	72.73%	72.73%	72.73%
/multisig/tests/scenario_go_test.rs	70.00%	70.00%	70.00%	70.00%
/test-caller/meta/src/main.rs	0.00%	0.00%	0.00%	0.00%
/test-caller/src/test-caller.rs	0.00%	0.00%	0.00%	0.00%

github-actions · 2024-08-22T08:16:30Z

Contract comparison - from b88edf9 to 1ca0e7d
⚠️ Warning: Could not download the report for the base branch. Displaying only the report for the current branch. ⚠️

Path	size	has-allocator	has-format
mx-bridge-eth-sc-rs
- bridge-proxy/bridge-proxy.wasm	12161	No	No
- bridged-tokens-wrapper/bridged-tokens-wrapper.wasm	8960	No	No
- esdt-safe/esdt-safe.wasm	24651	No	No
- multi-transfer-esdt/multi-transfer-esdt.wasm	16662	No	No
- multisig/multisig.wasm	27959	No	No
- test-caller/test-caller.wasm	3238	No	No

esdt-safe/src/lib.rs

multicontract added to remove onlyowner endpoint

esdt-safe/src/lib.rs

blackbox-esdt-safe

CostinCarabas

Solve clippy issues. Also sign commits.

…ntation # Conflicts: # esdt-safe/sc-config.toml # multi-transfer-esdt/src/lib.rs # multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs

dragos-rebegea · 2024-09-12T04:53:32Z

common/token-module/src/lib.rs

    #[endpoint(setTotalBalances)]
+    #[label("test-only")]


After the merge of feat/v3 setTotalBalances & setMintBalances can be deleted 👍

dragos-rebegea · 2024-09-12T04:56:39Z

esdt-safe/src/lib.rs

+        #[indexed] amount: BigUint,
+        #[indexed] fee: BigUint,
+        #[indexed] to: ManagedBuffer,
+        #[indexed] from: ManagedBuffer,
+        #[indexed] data: ManagedBuffer,


Suggested change

#[indexed] amount: BigUint,

#[indexed] fee: BigUint,

#[indexed] to: ManagedBuffer,

#[indexed] from: ManagedBuffer,

#[indexed] data: ManagedBuffer,

amount: BigUint,

fee: BigUint,

to: ManagedBuffer,

from: ManagedBuffer,

data: ManagedBuffer,

we can do the same for create_transaction_event

evelinemolnar and others added 8 commits August 21, 2024 12:58

first-commit

572773d

first-commit

729523d

quick renane

ba5677f

first-commit

5b0fcc4

Merge pull request #193 from multiversx/CII-49-create-common-transaction

76e620e

common transaction

Merge pull request #194 from multiversx/CII-50-event-sc-call

0a4312a

add sc event with data field

Merge branch 'feat-3.5-implementation' into CII-51-update-endpoint

0ddb6a1

Merge pull request #195 from multiversx/CII-51-update-endpoint

f4b38bc

update and create public endpoints that will call create_transaction_common

cosmatudor previously approved these changes Aug 27, 2024

View reviewed changes

CostinCarabas reviewed Aug 28, 2024

View reviewed changes

esdt-safe/src/lib.rs Outdated Show resolved Hide resolved

esdt-safe/src/lib.rs Outdated Show resolved Hide resolved

esdt-safe/src/lib.rs Outdated Show resolved Hide resolved

evelinemolnar and others added 16 commits August 29, 2024 09:06

99%

aa16150

small-fix

8dc7429

.

4d0776d

.

7e924dd

.

684183a

.

7361cc0

white-box

c20ded0

multi-contract

e9838c5

Merge pull request #201 from multiversx/remove-onlyownerv1

4084fc0

multicontract added to remove onlyowner endpoint

.

bfcce64

.

a0ebf2a

change upgrade to init

6b209f4

refactor - moved some tests in multitransafer blackbox

d8d7916

forgot to include a proxy file

3f02da5

fix case

0de0579

last-updates

d814e66

evelinemolnar dismissed cosmatudor’s stale review via d814e66 September 10, 2024 08:41

evelinemolnar requested a review from CostinCarabas September 10, 2024 08:54

evelinemolnar requested a review from cosmatudor September 10, 2024 08:54

evelinemolnar added 2 commits September 10, 2024 13:13

.

883ac77

.

a96cf44

CostinCarabas reviewed Sep 10, 2024

View reviewed changes

esdt-safe/src/lib.rs Outdated Show resolved Hide resolved

remove-duplicate-code

715cb14

evelinemolnar requested a review from CostinCarabas September 10, 2024 14:21

Merge pull request #198 from multiversx/CII-52

e5daccb

blackbox-esdt-safe

CostinCarabas reviewed Sep 11, 2024

View reviewed changes

clippy fixes

b36d232

evelinemolnar requested a review from CostinCarabas September 11, 2024 13:11

cosmatudor previously approved these changes Sep 11, 2024

View reviewed changes

dragos-rebegea dismissed cosmatudor’s stale review via b36d232 September 11, 2024 15:01

dragos-rebegea force-pushed the feat-3.5-implementation branch from c34a91b to b36d232 Compare September 11, 2024 15:01

dragos-rebegea added 4 commits September 11, 2024 18:07

Merge remote-tracking branch 'origin/feat/v3.5' into feat-3.5-impleme…

2b58348

…ntation # Conflicts: # esdt-safe/sc-config.toml # multi-transfer-esdt/src/lib.rs # multi-transfer-esdt/tests/multi_transfer_blackbox_test.rs

fix proxy after merge

e3e6fdc

fix clippy

8b86567

fix clippy

1ca0e7d

dragos-rebegea commented Sep 12, 2024

View reviewed changes

iulianpascalau merged commit 4bdab8a into feat/v3.5 Sep 12, 2024
5 checks passed

iulianpascalau deleted the feat-3.5-implementation branch September 12, 2024 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat 3.5 implementation #196

Feat 3.5 implementation #196

dragos-rebegea commented Aug 22, 2024

github-actions bot commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading

CostinCarabas left a comment

dragos-rebegea Sep 12, 2024

dragos-rebegea Sep 12, 2024

dragos-rebegea Sep 12, 2024

Feat 3.5 implementation #196

Feat 3.5 implementation #196

Conversation

dragos-rebegea commented Aug 22, 2024

github-actions bot commented Aug 22, 2024 • edited Loading

Coverage Summary

Totals

Files

github-actions bot commented Aug 22, 2024 • edited Loading

CostinCarabas left a comment

Choose a reason for hiding this comment

dragos-rebegea Sep 12, 2024

Choose a reason for hiding this comment

dragos-rebegea Sep 12, 2024

Choose a reason for hiding this comment

dragos-rebegea Sep 12, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 22, 2024 •

edited

Loading

github-actions bot commented Aug 22, 2024 •

edited

Loading