Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added navbar in reviews.html #381

Merged

Conversation

Rucha-Ambaliya
Copy link
Contributor

@Rucha-Ambaliya Rucha-Ambaliya commented Jan 14, 2025

Description

  • Added navbar
  • Ensured login button works
  • Checked functionality of hamburger

Related Issue

Fixes #376

Type of change

  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots

Recording.2025-01-15.214733.mp4

Copy link
Contributor

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 59979d1
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/678a67cbf150d8000855983b
😎 Deploy Preview https://deploy-preview-381--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Rucha-Ambaliya, the navbar works fine but there are few changes required in this PR:

  • Provide some top-margin to the Dataverse Reviews heading on the top.
    image

  • Set id="current" for Reviews link instead of the Home link to make it highlighted.
    image

@Rucha-Ambaliya
Copy link
Contributor Author

Thanks for pointing that out! I missed it while working on it. I'll push the necessary changes by tonight.

@Rucha-Ambaliya
Copy link
Contributor Author

Here, I have done the necessary changes, please let me know if it needs further improvements @Tejas-Gupta-7.

Recording.2025-01-17.195333.mp4

@multiverseweb multiverseweb merged commit cb5bff9 into multiverseweb:main Jan 17, 2025
5 checks passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #381 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WEBSITE] Add navbar to reviews page
2 participants