Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom alerts #346

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 15, 2024

Description

Added custom alerts, for the signup and login page. And I found out that there are similar functions that are needed on the main, login and signup page, therefore I moved them to a file called sharedUtilities.js, in which they are stored and used by simply importing them. This new file isn't only limited to this use, but it can be used for almost anything in the future. I also removed the <script> tag linking to the script.js file in the login page, since it wasn't doing much there, and might even cause some conflicts in the future. I tested everything, everything is working as I expected, across the three pages. (index, signup and login).

Related Issue

Fixes #341

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit e2290e3
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/6739eccf7e304e00083d8c65
😎 Deploy Preview https://deploy-preview-346--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@multiverseweb multiverseweb merged commit 8437cf9 into multiverseweb:main Nov 17, 2024
1 check passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #346 has been merged! 🎉🎉

@amin-xiv amin-xiv deleted the add-custom-alerts branch November 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] Show custom modals instead of default alert()
2 participants