Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to toggle between view/hide password in the signup … #315

Merged
merged 9 commits into from
Nov 7, 2024

Conversation

amin-xiv
Copy link
Contributor

@amin-xiv amin-xiv commented Nov 6, 2024

Description

Now the user can view/hide their password in both the signup and login page.

Related Issue

Fixes #144

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

toggle_password_visiblity

Copy link
Contributor

github-actions bot commented Nov 6, 2024

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

Copy link

netlify bot commented Nov 6, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit b80d3b7
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/672cf7a7fb6d530008843487
😎 Deploy Preview https://deploy-preview-315--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1
Copy link
Contributor

jency1 commented Nov 6, 2024

@amin-xiv Fix the alignment of toggle button, currently it's on the box.

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 6, 2024

Hi @jency1 , can you please clarify further? Thank you.

@multiverseweb
Copy link
Owner

Hi @amin-xiv here are the two changes required:

  • Avoid overlapping of eye image with text (can be done by adding background to the image)

Screenshot_2024-11-07-03-33-52-49_40deb401b9ffe8e1df2f1cc5ba480b12

  • Switch the images upon toggle.

eye-icons-set-password-eye-vision-illustration-sign-collection-suitable-for-design-element-of-user-login-ui-ux-free-vector

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 6, 2024

@multiverseweb Alright thanks for the clarification 👌

@amin-xiv
Copy link
Contributor Author

amin-xiv commented Nov 7, 2024

Hi @multiverseweb , I have updated it, what do you think now?
Edit: Whenever I go to deploy preview, and I start inputting a password in the field, I find out that there is an another password visibility toggle button, and I have no Idea from where it comes and it never appears to me locally, and when I go to inspect it in dev tools, it suddenly disappears.
Edit: I have just found out that it is a browser extension that is doing this, sorry for that 😅I am going to now restore the original code without the trials of fixing the 'bug'.

@jency1 jency1 merged commit a85d9cc into multiverseweb:main Nov 7, 2024
5 checks passed
Copy link
Contributor

github-actions bot commented Nov 7, 2024

🎉🎉 Thank you for your contribution! Your PR #315 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View password feature in login page and signup page
3 participants