-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to toggle between view/hide password in the signup … #315
Added the ability to toggle between view/hide password in the signup … #315
Conversation
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better. |
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@amin-xiv Fix the alignment of toggle button, currently it's on the box. |
Hi @jency1 , can you please clarify further? Thank you. |
Hi @amin-xiv here are the two changes required:
|
@multiverseweb Alright thanks for the clarification 👌 |
…xiv/Dataverse into toggle-password-visibility Merge toggle-password-visibility branch
Hi @multiverseweb , I have updated it, what do you think now? |
🎉🎉 Thank you for your contribution! Your PR #315 has been merged! 🎉🎉 |
Description
Now the user can view/hide their password in both the signup and login page.
Related Issue
Fixes #144
Type of change
Checklist