Fix #535: Map key bind interferes with race editor help #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added onClientResourceStart and onClientResourceStop event handlers to listen on the root element. When both the editor resource, and the race resource are active, it unbinds toggleMap from F2 When the editor resource is active, and you stop the race resource, it binds toggleMap back to F2. Since the help menu in Race is only active when the editor is active, this should really be the only time it should either bind or unbind the toggleMap.
jlillis
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added onClientResourceStart and onClientResourceStop event handlers to listen on the root element.
When both the editor resource, and the race resource are active, it unbinds toggleMap from F2
When the editor resource is active, and you stop the race resource, it binds toggleMap back to F2.
Since the help menu in Race is only active when the editor is active, this should really be the only time it should either bind or unbind the toggleMap.