freeroam: bugfix on fr_client.lua onExitVehicle function

[kutlu35]

There is no point of putting 'elseif' on that spesific place, it causes problems with anti-ramming system since it actually blocks the setVehicleGhost(vehicle,hasDriverGhost(vehicle)), it should be 'end if' instead. That way when driver of the vehicle exits the vehicle, ghostmode vehicle can be back to it's normal state.

VIDEO of the bug: https://youtu.be/ZRFNxSeI1Eo

[Dark-Dragon]

While that bit in the code seems to be structured more confusingly than necessary, I believe the point is to have the bottom part only apply for cases where it's not the vehicle of the local player and only for the "onClientPlayerVehicleExit" event. Whether that's important for the functionality of the script I'd need to test, but I wouldn't really agree that there is 'no point' unless you can provide more of an explanation.

[kutlu35]

While that bit in the code seems to be structured more confusingly than necessary, I believe the point is to have the bottom part only apply for cases where it's not the vehicle of the local player and only for the "onClientPlayerVehicleExit" event. Whether that's important for the functionality of the script I'd need to test, but I wouldn't really agree that there is 'no point' unless you can provide more of an explanation.

First part of the function is for destroying freeroam panel buttons such as 'repair', 'flip', 'color' when localPlayer exits vehicle, bottom part of the function is actually for changing the data of the vehicle when the DRIVER of the vehicle (seat == 0) exits the vehicle. For example we got "setVehicleGhost(vehicle,hasDriverGhost(vehicle))" there, this makes ghost vehicle normal vehicle again when a player that ticked 'anti ram' button exits the vehicle, but it won't actually happen. So this bug actually messes up the anti-ramming system. Also you can check the onEnterVehicle function which has same structure but it has "end if" instead of "elseif" and it works perfectly fine.

Here is a video:
https://youtu.be/ZRFNxSeI1Eo

[Dark-Dragon]

With the added context your change seems to restore the intended behavior.