Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chat messages sent twice #566

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Fix chat messages sent twice #566

merged 6 commits into from
Nov 13, 2024

Conversation

Fernando-A-Rocha
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha commented Oct 19, 2024 •
edited
Loading

Fixes #460

playercolors will no longer handle chat, as this is handled in the gamemode resource itself (freeroam), playercolors is just an extra resource.

@Dark-Dragon @Nico8340

@Fernando-A-Rocha
Copy link
Contributor Author

Fernando-A-Rocha commented Oct 19, 2024 •
edited
Loading

Other game modes that handle onPlayerChat and change its output to chatbox are:

  • TDM
  • CTV
  • Assault

Then, admin and webstats also handle onPlayerChat but don't alter its output.

@Dark-Dragon
Copy link
Contributor

Appropriate fix for while we wait for the large scale changes discussed in #463

@Fernando-A-Rocha
Copy link
Contributor Author

Exactly, this can be merged now.

@Fernando-A-Rocha
Copy link
Contributor Author

There you have it @jlillis

@jlillis jlillis merged commit 0547cf7 into multitheftauto:master Nov 13, 2024
1 check passed
@Fernando-A-Rocha Fernando-A-Rocha deleted the fix-chat-msg-twice branch November 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlillis jlillis jlillis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chat messages sent twice
3 participants
@Fernando-A-Rocha @Dark-Dragon @jlillis