-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialogs #467
Dialogs #467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Nico! There's even documentation :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, excellent documentation. Just one minor note about the code. I think it's also worth noting that while this is an improvement for all the resources that were using msgbox
previously, it won't work well for admin
and admin2
since those message boxes use coroutines rather than callback functions.
If nobody else has comments after a week or two I'll just send it. |
Nobody did, and it's been called excellent by more than 1 person, so let's merge. |
Description
This pull request was created to replace the existing msgbox resource. (Successor of #464)
Tasks
Add new resourceAdd documentationAdd deprecated warning to the old 'msgbox' resourceReplace old syntax in resourcesPreview
Functions
MessageBeep
Description
This function plays a sound from the messageSounds table.
Syntax
Example
Arguments
Returns
Returns the sound element.
MessageBox
Description
This function creates a dialog box with a callback function.
Syntax
Example
Arguments
Returns
This function does not contain returns because it uses a callback function.
MessageBoxEx
Description
This function creates a dialog box without a callback function.
Syntax
Example
Arguments
Returns
Returns as many buttons in order as specified in the messageButton argument.