Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misc repo files #249

Merged
merged 6 commits into from
Nov 13, 2020
Merged

Conversation

jlillis
Copy link
Contributor

@jlillis jlillis commented Nov 10, 2020

When merged this repo will add some miscellaneous repo files in the .github directory, including:

  • CODE_OF_CONDUCT.md (direct copy from mtasa-blue)
  • FUNDING.yml (direct copy from mtasa-blue)
  • SECURITY.md (direct copy from mtasa-blue

It also updates the security_report template to provide updated guidance on reporting vulnerabilities.

@qaisjp
Copy link
Contributor

qaisjp commented Nov 10, 2020

CODEOWNERS: I think we can remove lil_Toady and cazomino05 from CODEOWNERS. That would leave me being automatically assigned to admin2 PRs. If you're interested in driving admin2 forward, feel free to add yourself to it.

Coding style

  • I think we should leave Coding style for a separate PR just so that the rest of the changes in this PR don't get stuck behind thinking about specific style decisions.
  • IMO it's definitely worth at least discussing and documenting the ideal state, even if we can't autoformat or enforce it.
  • I think this repository should be a gold standard for what MTA resources look like (and it isn't that right now).
  • There's some additional context here about mass code formatting: Add .editorconfig file #247 (review).

@jlillis
Copy link
Contributor Author

jlillis commented Nov 10, 2020

You're right, I think I'll open up a discussion of coding style in a separate issue and leave this as it is for now.

I wasn't aware that CODEOWNERS had that functionality. I'll update it as you described.

@jlillis jlillis marked this pull request as ready for review November 10, 2020 23:28
@jlillis jlillis merged commit b0ccecd into multitheftauto:master Nov 13, 2020
@jlillis jlillis deleted the add-misc-repo-files branch November 22, 2020 23:25
@qaisjp qaisjp added this to the 1.6 milestone Nov 24, 2020
@patrikjuvonen patrikjuvonen modified the milestones: 1.6, 1.5.9 Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants