Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ped sync behavior #3965

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Nico8340
Copy link
Contributor

Fixes unexpected ped sync behavior after #3936

@Nico8340
Copy link
Contributor Author

cc @tederis

@tederis tederis added bugfix Solution to a bug of any kind backwards-incompatible Should be merged after the release of 1.6.1 labels Jan 18, 2025
@tederis
Copy link
Member

tederis commented Jan 18, 2025

This is potentially backwards incompatible. But due to the bit flags overlapping it may be hard to distinguish whether it pre-PR or post-PR behaviour. I think this could be merged without noticable issues.

See the explanation in Discord: https://discord.com/channels/801330706252038164/801411628600000522/1330055415760818208

@Nico8340 Nico8340 requested a review from tederis January 18, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatible Should be merged after the release of 1.6.1 bugfix Solution to a bug of any kind
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants