Add onExplosion event #3130
Add onExplosion event #3130
Conversation
| for (auto iter = m_pPlayerManager->IterBegin(); iter != m_pPlayerManager->IterEnd(); ++iter) | ||
| { | ||
| CPlayer* player = *iter; | ||
|
|
||
| CVector cameraPosition; | ||
| player->GetCamera()->GetPosition(cameraPosition); | ||
|
|
||
| // Is this players camera close enough to send? | ||
| if (IsPointNearPoint3D(explosionPosition, cameraPosition, MAX_EXPLOSION_SYNC_DISTANCE)) | ||
| { | ||
| sendList.push_back(player); | ||
| } | ||
| } |
There was a problem hiding this comment.
I suggest extract method here
There was a problem hiding this comment.
Is that logic reused somewhere?
There was a problem hiding this comment.
To improve readability and self-documenting.
|
Wouldn't this cause a desync for the player causing the explosion if cancelled (since it will have already happened on the source client)? |
The client waits for the server packet to actually create the explosion. |
sbx320
force-pushed
the
feature/on-explosion-event
branch
from
2c33c27
to
f6f63d0
Compare
|
Well, this was too quick, I wanted to add the event to createExplosion function on serverside. I forgot to mention this. |
|
Also, the origin element was not done right: it uses the closest player to an explosion, which is not the expected value in this event. |
This pull request adds the
onExplosionevent to the server-side and it can be cancelled. The event callback receives the absolute coordinates of the explosion, the explosion type, and the explosion origin (like a vehicle), if there is one.I haven't tested this event in a two-or-more player scenario yet, but it worked locally for me.