Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2965: sourceResourceRoot is incorrect in event handlers #3031

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Fix #2965: sourceResourceRoot is incorrect in event handlers #3031

wants to merge 22 commits into from

Conversation

TracerDS
Copy link
Contributor

Currently MTA is pushing dynamic resource root element instead of normal resource root element.
Changing it from GetResourceDynamicEntity to GetResourceEntity fixes the issue

@TracerDS
Fix multitheftauto#2965: sourceResourceRoot is incorrect in event han…
3b5ae6f 
…dlers

Currently MTA is pushing **dynamic** resource root element instead of normal resource root element.
Changing it from `GetResourceDynamicEntity` to `GetResourceEntity` fixes the issue
@CrosRoad95
Copy link
Contributor

i see one problem with this fix: people may already depend on this bug in their existing resources so now you are breaking them

@TracerDS
Copy link
Contributor Author

TracerDS commented May 22, 2023 •
edited
Loading

i see one problem with this fix: people may already depend on this bug in their existing resources so now you are breaking them

maybe its time to stop relying on bugs ¯\(ツ)/¯

@ds1-e
Copy link
Contributor

ds1-e commented May 22, 2023

I guess you can still do that, and it can be pushed to 1.6 branch - because this version already breaks some stuff, see: https://wiki.multitheftauto.com/wiki/Changes_in_1.6
obraz

@CrosRoad95 CrosRoad95 mentioned this pull request May 23, 2023
Merged
@lopezloo lopezloo added the bug Something isn't working label May 23, 2023
@lopezloo lopezloo linked an issue May 23, 2023 that may be closed by this pull request
sourceResourceRoot is incorrect in event handlers #2965
Open
1 task
@TracerDS TracerDS closed this Jul 4, 2023
@TracerDS TracerDS deleted the 220523_Fix_#2965 branch July 4, 2023 19:44
@TracerDS TracerDS restored the 220523_Fix_#2965 branch July 5, 2023 07:33
@TracerDS TracerDS reopened this Jul 5, 2023
@botder
Copy link
Member

botder commented Jul 26, 2023

I think it's too late to push this with 1.6, maybe next time.

@botder botder added backwards-incompatible Should be merged after the release of 1.6.1 bugfix Solution to a bug of any kind and removed bug Something isn't working labels Sep 19, 2023
@Fernando-A-Rocha
Copy link
Contributor

1.6.1 ?

@TracerDS
Copy link
Contributor Author

TracerDS commented May 5, 2024

1.6.1 ?

It was actually ready for 1.6 but this PR didnt get enough attention 😢

@Fernando-A-Rocha
Copy link
Contributor

1.6.1 ?

It was actually ready for 1.6 but this PR didnt get enough attention 😢

It's never too late!

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Oct 30, 2024 •
edited
Loading

Marge, or put this in wiki breaking changes? Idk the procedure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backwards-incompatible Should be merged after the release of 1.6.1 bugfix Solution to a bug of any kind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sourceResourceRoot is incorrect in event handlers
6 participants
@TracerDS @CrosRoad95 @ds1-e @botder @Fernando-A-Rocha @lopezloo