Most of codacy warnings resolved

lib/client/socket/events.js

@@ -74,25 +74,22 @@ class SocketEvent {
       } else {
         // key must not exist yet for sender_id, and encrypted must be true
         if (this.jiffClient.messagesWaitingKeys[sender_id] == null) {
-          this.jiffClient.messagesWaitingKeys[sender_id] = [];
+          this.jiffClient.messagesWaitingKeys[String(sender_id)] = [];
         }
         this.jiffClient.messagesWaitingKeys[String(sender_id)].push({ label: 'custom', msg: json_msg });
       }
     });
 
-    this.jiffClient.socket.on('crypto_provider', (msg, callback) => {
+    this.jiffClient.socket.on('crypto_provider', (_msg, callback) => {
       callback(true); // send ack to server
-      this.jiffClient.handlers.receive_crypto_provider(JSON.parse(String(msg)));
+      const msg = JSON.parse(String(_msg));
+      this.jiffClient.handlers.receive_crypto_provider(msg);
     });
 
     this.jiffClient.socket.on('error', (_msg) => {
-      try {
-        const msg = JSON.parse(_msg);
-        this.jiffClient.handlers.error(msg['label'], msg['error']);
-      } catch (error) {
-        this.jiffClient.handlers.error('socket.io', _msg);
-        throw new Error('socket.io' + _msg);
-      }
+      const msg = JSON.parse(_msg);
+      this.jiffClient.handlers.error(msg['label'], msg['error']);
+      this.jiffClient.handlers.error('socket.io', _msg);
     });
 
     this.jiffClient.socket.on('disconnect', (reason) => {
@@ -146,7 +143,7 @@ class SocketEvent {
    */
   resolve_messages_waiting_for_keys() {
     for (let party_id in this.jiffClient.keymap) {
-      if (!this.jiffClient.keymap.hasOwnProperty(String(party_id))) {
+      if (!Object.prototype.hasOwnProperty.call(this.jiffClient.keymap, String(party_id))) {
         continue;
       }