Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new changelog design #7467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Jan 15, 2025

This PR provides new face for changelog view. In addition, It makes it accessible through Settings view.

Before After
Image 2

This change is Reviewable

@mojganii mojganii added iOS Issues related to iOS feature request For issues asking for new features labels Jan 15, 2025
@mojganii mojganii self-assigned this Jan 15, 2025
Copy link

linear bot commented Jan 15, 2025

@mojganii mojganii force-pushed the add-a-changelog-view-ios-988 branch from cbca8a7 to a93c430 Compare January 15, 2025 14:23
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPN/Views/MainButton.swift line 11 at r1 (raw file):

import SwiftUI
enum ImagePosition {
    case leading

nit
This feels quite a generic name for something that's only used by the MainButton
I think we should rename it MainButtonImagePosition, or maybe move that enum down in the MainButton struct instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request For issues asking for new features iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants