Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route to obfuscator on relay (if applicable) #7459

Merged

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Jan 13, 2025

This PR fixes a bug where the wrong route(s) would be added when Shadowsocks obfuscation with extra in IPs where used. Previously, we would always add a route to the relay's public IP, but not to the obfuscator.


This change is Reviewable

Copy link

linear bot commented Jan 13, 2025

dlon
dlon previously approved these changes Jan 13, 2025
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 force-pushed the shadowsocks-not-working-with-new-servers-des-1634 branch from 554ca03 to ee94ef7 Compare January 13, 2025 16:32
@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review January 13, 2025 16:33
@MarkusPettersson98 MarkusPettersson98 force-pushed the shadowsocks-not-working-with-new-servers-des-1634 branch from ee94ef7 to 03c4f21 Compare January 13, 2025 16:33
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 force-pushed the shadowsocks-not-working-with-new-servers-des-1634 branch from 03c4f21 to 07905aa Compare January 14, 2025 08:35
@MarkusPettersson98 MarkusPettersson98 merged commit 5ef7ee1 into main Jan 14, 2025
57 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the shadowsocks-not-working-with-new-servers-des-1634 branch January 14, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants