Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert disallowing keychain items to be excluded from backups. #7455

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Jan 13, 2025

The team has decided to go back to the drawing board on this work to make it better.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Jan 13, 2025
@buggmagnet buggmagnet self-assigned this Jan 13, 2025
Copy link

linear bot commented Jan 13, 2025

@buggmagnet buggmagnet force-pushed the revert-excluding-keychains-from-backups-ios-1007 branch 2 times, most recently from cba1216 to 1f04bc1 Compare January 13, 2025 09:34
@buggmagnet buggmagnet requested a review from rablador January 13, 2025 12:53
@buggmagnet buggmagnet force-pushed the revert-excluding-keychains-from-backups-ios-1007 branch from 1f04bc1 to 6248972 Compare January 13, 2025 12:53
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit 525aaa0 into main Jan 13, 2025
12 checks passed
@buggmagnet buggmagnet deleted the revert-excluding-keychains-from-backups-ios-1007 branch January 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants