-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Whitelist relays in an end to end test framwork config #7454
base: main
Are you sure you want to change the base?
Whitelist relays in an end to end test framwork config #7454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 18 files reviewed, 1 unresolved discussion (waiting on @Serock3)
test/test-manager/src/config/manifest.rs
line 32 at r2 (raw file):
/// The above example will set the locations for the test `daita` to a custom list containing /// `se-got-wg-001` and `se-got-wg-002`. The `*` is a wildcard that will match any test /// name. The order of the list is important, as the first match will be used.
We should mention that the pattern is a glob pattern, which has a specification. Otherwise, it will be hard to figure out how to write the test patterns 😊
Code quote:
/// The above example will set the locations for the test `daita` to a custom list containing
/// `se-got-wg-001` and `se-got-wg-002`. The `*` is a wildcard that will match any test
/// name. The order of the list is important, as the first match will be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 20 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-manager/src/config/manifest.rs
line 32 at r2 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
We should mention that the pattern is a glob pattern, which has a specification. Otherwise, it will be hard to figure out how to write the test patterns 😊
Done. I clarified the format in text in addition to the format.
Picking up the work started by @MarkusPettersson98, with the new format decided in https://linear.app/mullvad/issue/DES-1052/be-able-to-whitelist-relays-in-an-end-to-end-test-run.
This change is