Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use new header components #7447

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

olmoh
Copy link
Collaborator

@olmoh olmoh commented Jan 10, 2025

Adds two new components:

  • NavigationHeader
  • MainHeader

These are implemented as logic agnostic components in the lib folder and extended and used in the app.


This change is Reviewable

Copy link

linear bot commented Jan 10, 2025

@olmoh olmoh force-pushed the change-paddings-in-main-nav-header-des-1150 branch from f81513e to ea75d4b Compare January 10, 2025 10:06
@olmoh olmoh marked this pull request as ready for review January 13, 2025 08:12
@olmoh olmoh force-pushed the change-paddings-in-main-nav-header-des-1150 branch from d9e71cc to 6c5fe54 Compare January 13, 2025 08:44
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 1 of 1 files at r5, 6 of 6 files at r6, 6 of 6 files at r7, 1 of 1 files at r8, 10 of 10 files at r9, 8 of 8 files at r10, 33 of 33 files at r11, 2 of 2 files at r12, 1 of 1 files at r13, 6 of 6 files at r14, 6 of 6 files at r15, 1 of 1 files at r16, 10 of 10 files at r17, 7 of 8 files at r18.
Reviewable status: 14 of 79 files reviewed, all discussions resolved

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 8 files at r18, 5 of 5 files at r19, 33 of 35 files at r20, 1 of 1 files at r21, 15 of 15 files at r22, 9 of 9 files at r23, 1 of 1 files at r24, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98 MarkusPettersson98 force-pushed the change-paddings-in-main-nav-header-des-1150 branch from 6c5fe54 to 9d1f8c5 Compare January 13, 2025 14:03
@MarkusPettersson98 MarkusPettersson98 merged commit 6502047 into main Jan 13, 2025
11 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the change-paddings-in-main-nav-header-des-1150 branch January 13, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants