Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle rust android plugin #7446

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Jan 10, 2025

The plugin would not correctly realize changes made to the native code. Related issue:

mozilla/rust-android-gradle#118 (comment)


This change is Reviewable

Copy link

linear bot commented Jan 10, 2025

@Rawa Rawa self-assigned this Jan 10, 2025
@Rawa Rawa added the Android Issues related to Android label Jan 10, 2025
@Rawa Rawa force-pushed the gradle-plugin-does-not-bundle-updated-so-file-droid-1723 branch 4 times, most recently from 1f93976 to ebc05d1 Compare January 10, 2025 14:14
@Pururun Pururun self-requested a review January 10, 2025 14:18
@Pururun Pururun force-pushed the gradle-plugin-does-not-bundle-updated-so-file-droid-1723 branch from ebc05d1 to 40565b5 Compare January 10, 2025 14:27
Pururun
Pururun previously approved these changes Jan 10, 2025
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the gradle-plugin-does-not-bundle-updated-so-file-droid-1723 branch from 40565b5 to f7add3c Compare January 10, 2025 14:48
@Rawa Rawa requested review from Pururun, kl and albin-mullvad January 10, 2025 14:49
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the gradle-plugin-does-not-bundle-updated-so-file-droid-1723 branch from f7add3c to b37f519 Compare January 10, 2025 15:01
@Rawa Rawa merged commit 5ff903a into main Jan 10, 2025
25 checks passed
@Rawa Rawa deleted the gradle-plugin-does-not-bundle-updated-so-file-droid-1723 branch January 10, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants