-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use constraints in UI state for FilterScreen #7389
Conversation
26beec9
to
b9b7ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Rawa)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/state/RelayFilterUiState.kt
line 35 at r1 (raw file):
providerToOwnerships .filterValues { selectedOwnership.value in it } .keys
Should probaby be an extensionfunction
android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/Providers.kt
line 3 at r1 (raw file):
package net.mullvad.mullvadvpn.lib.model typealias Providers = List<ProviderId>
Great that this removed. ⭐
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt
line 125 at r1 (raw file):
if (ownershipExpanded) { item(key = Keys.OWNERSHIP_ALL, contentType = ContentType.ITEM) { AnyOwnership(state, { onSelectedOwnership(Constraint.Any) })
I think this should probably be moved back into the AnyOwnership
function.
405dd61
to
6f784d0
Compare
0529627
to
04d9fb7
Compare
cbbb316
to
99bd279
Compare
3ae34f3
to
db9b326
Compare
8a31408
to
a220f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 15 files reviewed, 3 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/FilterScreen.kt
line 125 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
I think this should probably be moved back into the
AnyOwnership
function.
Not sure what was changed, but it has not been touched now. Fixed
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/state/RelayFilterUiState.kt
line 35 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Should probaby be an extensionfunction
Simplified now.
android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/Providers.kt
line 3 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Great that this removed. ⭐
Done.
07ee0d1
to
3d9e23f
Compare
3d9e23f
to
cc36677
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is