Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement increased power consumption warning #7352

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Dec 17, 2024


This change is Reviewable

@Rawa Rawa added the Android Issues related to Android label Dec 17, 2024
@Rawa Rawa self-assigned this Dec 17, 2024
Copy link

linear bot commented Dec 17, 2024

@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from cd14f28 to be884e5 Compare December 17, 2024 08:45
@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from be884e5 to 2dd87a2 Compare December 17, 2024 09:03
Pururun
Pururun previously approved these changes Dec 17, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/lib/resource/src/main/res/values/strings.xml line 424 at r1 (raw file):

    <string name="open_feature_settings">Open %1$s settings</string>
    <string name="search">Search</string>
    <string name="obfuscation_info_shadowsocks_batteryusage">Attention: using Shadowsocks increases battery consumption with heavy data usage.</string>

Nit: I find this sentence a bit confusing. Should it not be "together with increased data usage". I think just with is not really understandable and heavy also feels a bit weird.

@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from 2dd87a2 to 277b425 Compare December 17, 2024 13:31
@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from 277b425 to 61eb3e8 Compare December 17, 2024 13:52
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/lib/resource/src/main/res/values/strings.xml line 424 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Nit: I find this sentence a bit confusing. Should it not be "together with increased data usage". I think just with is not really understandable and heavy also feels a bit weird.

Updated the text.

Pururun
Pururun previously approved these changes Dec 17, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


android/lib/resource/src/main/res/values/strings.xml line 424 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

Updated the text.

Much better. :)

@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from 61eb3e8 to 0d683a2 Compare December 17, 2024 14:03
@Rawa Rawa requested a review from Pururun December 17, 2024 14:04
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the implement-increased-power-consumption-warning-droid-1581 branch from 0d683a2 to 745821a Compare December 17, 2024 15:23
@Rawa Rawa merged commit 40affe2 into main Dec 17, 2024
35 checks passed
@Rawa Rawa deleted the implement-increased-power-consumption-warning-droid-1581 branch December 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants