-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement increased power consumption warning #7352
Implement increased power consumption warning #7352
Conversation
cd14f28
to
be884e5
Compare
be884e5
to
2dd87a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/lib/resource/src/main/res/values/strings.xml
line 424 at r1 (raw file):
<string name="open_feature_settings">Open %1$s settings</string> <string name="search">Search</string> <string name="obfuscation_info_shadowsocks_batteryusage">Attention: using Shadowsocks increases battery consumption with heavy data usage.</string>
Nit: I find this sentence a bit confusing. Should it not be "together with increased data usage". I think just with is not really understandable and heavy also feels a bit weird.
2dd87a2
to
277b425
Compare
277b425
to
61eb3e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/lib/resource/src/main/res/values/strings.xml
line 424 at r1 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Nit: I find this sentence a bit confusing. Should it not be "together with increased data usage". I think just with is not really understandable and heavy also feels a bit weird.
Updated the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
android/lib/resource/src/main/res/values/strings.xml
line 424 at r1 (raw file):
Previously, Rawa (David Göransson) wrote…
Updated the text.
Much better. :)
61eb3e8
to
0d683a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
0d683a2
to
745821a
Compare
This change is