Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream changes from "Windows ARM in test framework"-investigation #7316

Merged

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Dec 10, 2024

This PR upstreams changes in preparation of running a Windows ARM guest in the test framework. None of these changes should break any existing VMs, they should be strict improvements upon the current code.


This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 force-pushed the upstream-changes-from-windows-arm-e2e-experiment branch 13 times, most recently from fbfc30d to 3085bea Compare December 16, 2024 15:55
@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review December 16, 2024 16:06
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


test/test-manager/src/main.rs line 274 at r1 (raw file):

            let vm_config = vm::get_vm_config(&config, &vm).context("Cannot get VM config")?;
            let test_runner = TargetInfo::try_from(vm_config)?;

The name test_runner doesn't feel right to me. It's the architecture of the test runner, right? I expected it to be a handle to the rpc, or something similar. Maybe runner_target?

@MarkusPettersson98 MarkusPettersson98 force-pushed the upstream-changes-from-windows-arm-e2e-experiment branch from 3085bea to e83220f Compare December 17, 2024 05:33
Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @Serock3)


test/test-manager/src/main.rs line 274 at r1 (raw file):

Previously, Serock3 (Sebastian Holmin) wrote…

The name test_runner doesn't feel right to me. It's the architecture of the test runner, right? I expected it to be a handle to the rpc, or something similar. Maybe runner_target?

runner_target makes sense! Updated 😊

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Fix SCP not working on well with Windows guests. Switch over to
SFTP instead
@MarkusPettersson98 MarkusPettersson98 force-pushed the upstream-changes-from-windows-arm-e2e-experiment branch from e83220f to 72ef110 Compare December 17, 2024 10:54
@MarkusPettersson98 MarkusPettersson98 force-pushed the upstream-changes-from-windows-arm-e2e-experiment branch from 72ef110 to 6ea9b99 Compare December 17, 2024 11:00
@MarkusPettersson98 MarkusPettersson98 merged commit a6b6f09 into main Dec 17, 2024
40 checks passed
@MarkusPettersson98 MarkusPettersson98 deleted the upstream-changes-from-windows-arm-e2e-experiment branch December 17, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants