-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for android 2024.9-beta1
#7244
Update changelog for android 2024.9-beta1
#7244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @Pururun)
android/src/main/play/release-notes/en-US/default.txt
line 1 at r1 (raw file):
- Fixed a case where the app would freeze.
nit: suggested rephrasing to clarify a bit Fixed an issue where the app could freeze (ANR).
Code quote:
a case
android/src/main/play/release-notes/en-US/default.txt
line 1 at r1 (raw file):
- Fixed a case where the app would freeze.
No mention of EDP? 😱
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
- Fixed a case where the app would freeze. - Fixed an issue with account expiry notifications not showing.
Looks like a trailing space in Reviewable. Also we fixed a related bug with where we didn't handle out-of-time correctly. Maybe we can write something like:
Fixed a few issues related to account expiry notifications and the behavior when the account has expired.
android/src/main/play/release-notes/en-US/default.txt
line 3 at r1 (raw file):
- Fixed a case where the app would freeze. - Fixed an issue with account expiry notifications not showing. - Improve animations.
Looks like a bad EOF in Reviewable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 3 unresolved discussions (waiting on @albin-mullvad)
android/src/main/play/release-notes/en-US/default.txt
line 1 at r1 (raw file):
Previously, albin-mullvad wrote…
nit: suggested rephrasing to clarify a bit
Fixed an issue where the app could freeze (ANR).
Done
android/src/main/play/release-notes/en-US/default.txt
line 1 at r1 (raw file):
Previously, albin-mullvad wrote…
No mention of EDP? 😱
Missed that, thanks.
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
Previously, albin-mullvad wrote…
Looks like a trailing space in Reviewable. Also we fixed a related bug with where we didn't handle out-of-time correctly. Maybe we can write something like:
Fixed a few issues related to account expiry notifications and the behavior when the account has expired.
Done
android/src/main/play/release-notes/en-US/default.txt
line 3 at r1 (raw file):
Previously, albin-mullvad wrote…
Looks like a bad EOF in Reviewable
Done
96c4c75
to
5eac036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This change is