Fix daita and multihop warning being shown when multihop is disabled

[olmoh]

Since the directOnly boolean is separate from the multihop setting we need to check the multihop setting as well before disabling the entry selection.

---

This change is 

[linear]

DES-1506 "Daita + Multihop" warning is shown in select location view after disabling multihop

[hulthe]

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @olmoh)

---

desktop/packages/mullvad-vpn/src/renderer/components/select-location/SelectLocation.tsx line 313 at r1 (raw file):

        <CustomLists selectedElementRef={selectedLocationRef} onSelect={onSelectEntryRelay} />
        <LocationList
          key={locationType}

If we end up in this branch, locationType will be set to Entry. I think that would mean the LocationList shown here will have the wrong list of relays... We probably want to ensure that locationType is always set to exit when multihop is disabled.

[hulthe]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @olmoh)

---

desktop/packages/mullvad-vpn/src/renderer/components/select-location/SelectLocation.tsx line 313 at r1 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

If we end up in this branch, locationType will be set to Entry. I think that would mean the LocationList shown here will have the wrong list of relays... We probably want to ensure that locationType is always set to exit when multihop is disabled.

Hmm. this appears to be a bug that's been around longer than the daita-warning-bug. It's present in 2024.7.

To reproduce:

• Enable multihop
• Click "entry" in location view
• Disable multihop
• Select a new location

[hulthe]

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @olmoh)

[hulthe]

Reviewable status: complete! all files reviewed, all discussions resolved

[hulthe]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Serock3]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved