Use low latency servers for all tests #7184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusPettersson98
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
test/test-manager/src/tests/helpers.rs line 1328 at r1 (raw file):
// The typestate query builder cannot express openVPN bridge locations while specifying // wireguard options, like multihop. So we need to create a new query for openVPN, and
⛏️ OpenVPN*
Code quote:
openVPN
Serock3
force-pushed
the
use-low-latency-servers-for-more-tests-des-1448
branch
from
096994a to
2df8f1e
Compare
MarkusPettersson98
previously approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
Serock3
force-pushed
the
use-low-latency-servers-for-more-tests-des-1448
branch
3 times, most recently
from
8939bcb to
77eea44
Compare
Serock3
force-pushed
the
use-low-latency-servers-for-more-tests-des-1448
branch
3 times, most recently
from
630e164 to
c880e66
Compare
There was a problem hiding this comment.
Reviewed 3 of 4 files at r4, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved
Serock3
force-pushed
the
use-low-latency-servers-for-more-tests-des-1448
branch
from
7cbd4fa to
d634d16
Compare
MarkusPettersson98
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status:
When starting e2e tests on multiple platforms, we always specify the same list of tests for all paltforms. Therefore we should not fail on parsing a test that is skipped for the current platform.
Add to `prepare_daemon` a step where the default location, including for multihop and bridges, is set to the `Nordic` custom list.
Serock3
force-pushed
the
use-low-latency-servers-for-more-tests-des-1448
branch
from
d634d16 to
1ff1dcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to
prepare_daemona step where the default location, including entry for multihop (but not bridges as it turned out to be problematic), is set to theNordiccustom list.Link to full test run https://github.com/mullvad/mullvadvpn-app/actions/runs/11892409373/job/33137399707. I left in a
dbg!()statement by accident, so the logs are a little cluttered.This change is