Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .replaceDevicePrivateKey() value to PacketTunnelActor's Command enum #5960

Conversation

acb-mv
Copy link
Contributor

@acb-mv acb-mv commented Mar 14, 2024

This is currently a no-op and nothing sends it, but it is there for passing the key to the actor.

Also, Command is now PacketTunnelActor.Command. This is less ambiguous and polluting of namespace than having a globally scoped type named Command that serves only to couple two components; the other alternative was naming it PacketTunnelActorCommand, but for the cost of one character, the prefix disappears when in scope.


This change is Reviewable

@acb-mv acb-mv requested a review from buggmagnet March 14, 2024 14:26
@acb-mv acb-mv self-assigned this Mar 14, 2024
Copy link

linear bot commented Mar 14, 2024

@buggmagnet buggmagnet added the iOS Issues related to iOS label Mar 15, 2024
@buggmagnet buggmagnet requested a review from rablador March 15, 2024 07:30
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to change the type for the new command introduced, but looks good otherwise.

Reviewed 1 of 5 files at r1, 2 of 4 files at r2, all commit messages.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @acb-mv)


ios/PacketTunnelCore/Actor/PacketTunnelActorCommand.swift line 40 at r2 (raw file):

        /// Update the device private key, as per post-quantum protocols
        case replaceDevicePrivateKey(PrivateKey)

The type should be a SharedKey here (it already exists in WireguardKitTypes)

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 3 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @acb-mv)

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the add-packettunnelactor-command-value-for-passing-negotiated-ios-552 branch from f932aab to dcefe58 Compare March 15, 2024 12:16
@buggmagnet buggmagnet merged commit 0a3c63a into main Mar 15, 2024
5 of 7 checks passed
@buggmagnet buggmagnet deleted the add-packettunnelactor-command-value-for-passing-negotiated-ios-552 branch March 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants