Use collectAsStateWithLifecycle

[Rawa]

Use collectAsStateWithLifecycle, and ensure all uses state as variable name instead of uiState.

---

This change is 

[linear]

DROID-563 Start using collectAsStateWithLifecycle

[albin-mullvad]

Reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

Looks good, just a small thought since this PR does two things that is easy to miss in a future feature, do we want to add some konsist check for using collectAsLifecycle and that we want to call the state state and not uiState?

Reviewed 3 of 3 files at r2.
Reviewable status: 24 of 31 files reviewed, all discussions resolved (waiting on @albin-mullvad)

[albin-mullvad]

Reviewed 3 of 3 files at r2, 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Rawa]

Konsist does not allow for inspecting the variable names, only the signatures of methods and also import statements. So the alternatives would be:

1. Ensure no composables take an argument that is named uiState
2. We never import function collectAsState

Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Both of those makes sense imo. Should be quite straight forward to add, right? I would say we go ahead and add those 🚀

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[Pururun]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved