Do daemon uniqueness check before rotating logs #5847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulthe
changed the title
hulthe
force-pushed
the
uniqueness-check-before-logrotate
branch
from
58edea8 to
ea5b0ef
Compare
dlon
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
hulthe
force-pushed
the
uniqueness-check-before-logrotate
branch
from
ea5b0ef to
95766db
Compare
dlon
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
dlon
force-pushed
the
uniqueness-check-before-logrotate
branch
from
95766db to
f60a9c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5763
Moved RPC uniqueness check to before logging is initialized (and log file is rotated). Consequently, this means that we won't get any log output from
runtime.buildor the uniqueness check, but that's probably fine.Not sure how this interacts with the
initialize_firewall_and_exitmode, needs to be tested.This change is