Add tests for custom SOCKS bridges #5779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
testing-add-socks-bridge-tests
branch
from
2b3187a to
228bb05
Compare
dlon
force-pushed
the
testing-add-socks-bridge-tests
branch
from
68af67a to
bf57e44
Compare
dlon
force-pushed
the
testing-add-socks-server
branch
from
f30d6d1 to
eed7234
Compare
dlon
force-pushed
the
testing-add-socks-bridge-tests
branch
from
bf57e44 to
10ac362
Compare
MarkusPettersson98
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
test/test-manager/src/tests/tunnel.rs line 698 at r1 (raw file):
bridge_type: BridgeType::Custom, normal: BridgeConstraints::default(), custom: Some(CustomProxy::Socks5Local(Socks5Local::new(
Nit: We could use Socks5Local::new_with_transport_protocol here to be explicit about using TCP. Using new will default to TCP, so it is fine to leave it as is 😊
Code quote:
Socks5Local::new
dlon
force-pushed
the
testing-add-socks-bridge-tests
branch
from
9659e8c to
e1a194c
Compare
MarkusPettersson98
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes DES-609.
This change is