Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pin serialport to a fork. Use upgraded upstream version 4.3.0 #5726

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

faern
Copy link
Member

@faern faern commented Jan 25, 2024

This PR does not look like much, but it has a bunch of nice outcomes:

  • Gets rid of a git dependency. Git dependencies are not good, since the availability of a specific git repo or commit is harder to maintain than crates.io dependencies. Especially since we have not (yet) pushed any tag to the pinned commit even 🙈 (we really should do that in order to be able to build older versions of the testframework)
  • Fixes RUSTSEC-2020-0168 by getting rid of the transitive dependency mach that is unmaintained.
  • Getting rid of some really outdated and unmaintained macOS bindings.

This change is Reviewable

@faern faern requested a review from dlon January 25, 2024 09:36
@faern faern force-pushed the upgrade-serialport branch 3 times, most recently from 43942d8 to 1900dd9 Compare January 25, 2024 13:17
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: except the formatting that CI complains about.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faern faern force-pushed the upgrade-serialport branch from 1900dd9 to 9cf4b2f Compare February 1, 2024 09:16
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faern faern marked this pull request as ready for review February 1, 2024 10:05
@faern faern force-pushed the upgrade-serialport branch from bfc3eae to 43f31c7 Compare February 1, 2024 12:17
@faern faern merged commit 09cfec2 into main Feb 1, 2024
31 checks passed
@faern faern deleted the upgrade-serialport branch February 1, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants