Fix test_installation_idempotency #5699
Conversation
dlon
force-pushed
the
testing-fix-idempotency-test
branch
from
84aa496 to
14096b9
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
test/test-manager/src/tests/install.rs line 293 at r2 (raw file):
.set_auto_connect(false) .await .expect("failed to enable auto-connect");
Why not manually set auto connect to false anymore? It is explicitly mentioned in the changelog entry and the doc-comment after all 😊
Code quote:
// Disable auto-connect
mullvad_client
.set_auto_connect(false)
.await
.expect("failed to enable auto-connect");
dlon
force-pushed
the
testing-fix-idempotency-test
branch
from
14096b9 to
303c8d2
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
test/test-manager/src/tests/install.rs line 293 at r2 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
Why not manually set auto connect to
falseanymore? It is explicitly mentioned in the changelog entry and the doc-comment after all 😊
Done!
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
test/test-manager/src/tests/install.rs line 293 at r2 (raw file):
Previously, dlon (David Lönnhager) wrote…
Done!
🙌
The test currently fails when the daemon is not logged in. This always happens since
test_loginruns after this test.This PR fixes it by failing whenever the daemon starts in the
disconnectedstate instead.Close DES-565.
This change is