Fix broken e2e tests

[sabercodic]

After migration into android compose and lack of IDs some of ui automate tests stops working.
this are the fixes:

• LoginTest
• ConnectionTest
• WebLinkTest

---

This change is 

[linear]

DROID-609 Fix broken e2e tests

[Pururun]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sabercodic)

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/interactor/AppInteractor.kt line 81 at r1 (raw file):

        return device
            .findObjectWithTimeout(
                By.res("location_info_connection_out_test_tag"),

I will create an issue for this, really silly that we can't use the constants here.

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 28 at r1 (raw file):

    @JvmField
    val permissionRule: GrantPermissionRule =
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {

Why was this removed?

[sabercodic]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/interactor/AppInteractor.kt line 81 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I will create an issue for this, really silly that we can't use the constants here.

created, please chack it: https://linear.app/mullvad/issue/DROID-610/make-constraints-accessible-for-the-test-modules

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 28 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Why was this removed?

The reason to add this permission in first place was to cover storage permission in new android versions, on this PR I find that it is just for our own storage access and we just need it for take screen shots and based on documentations App does not need any extra permission for this: https://developer.android.com/training/data-storage/shared/media#storage-permission-not-always-needed

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

---

android/test/common/src/main/kotlin/net/mullvad/mullvadvpn/test/common/interactor/AppInteractor.kt line 81 at r1 (raw file):

Previously, sabercodic wrote…

created, please chack it: https://linear.app/mullvad/issue/DROID-610/make-constraints-accessible-for-the-test-modules

Nice 👍

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 28 at r1 (raw file):

Previously, sabercodic wrote…

The reason to add this permission in first place was to cover storage permission in new android versions, on this PR I find that it is just for our own storage access and we just need it for take screen shots and based on documentations App does not need any extra permission for this: https://developer.android.com/training/data-storage/shared/media#storage-permission-not-always-needed

Ah ok, as long as it works that's fine, but I guess we should not request write and read external storage for newer versions of android if it is not needed?

[sabercodic]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 28 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Ah ok, as long as it works that's fine, but I guess we should not request write and read external storage for newer versions of android if it is not needed?

yes

[Pururun]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[albin-mullvad]

Reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sabercodic)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 34 at r2 (raw file):

            )
        } else {
            null

Has this been verified on multiple API levels? Remember that screenshots are only taken if the tests are failing.

Code quote:

null

[sabercodic]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/test/e2e/src/main/kotlin/net/mullvad/mullvadvpn/test/e2e/EndToEndTest.kt line 34 at r2 (raw file):

Previously, albin-mullvad wrote…

Has this been verified on multiple API levels? Remember that screenshots are only taken if the tests are failing.

Yes, It tested on Android 8, 10, 12 and 14

[albin-mullvad]

Reviewable status: complete! all files reviewed, all discussions resolved