Try to mitigate missing relay list errors

[Pururun]

This PR tries to make situations where a user would see an empty relay list rarer by trying to mitigate some potential sources for this error in the app layer.
The two changes are:

1. Change from SharingStarted.Eagerly to SharingStarted.WhileSubscribed(). This, according to my tests, delays the call to fetch the relay list by around 400 ms. This in my opinion could make things less likely to break since the call is made later and thus the call (or the answer) is less likely be lost.
2. Make a call to get the relay list again when entering the SelectLocationScreen. This would mean that if the user still encounters this error it can be resolved when they opening the actual screen. It still would cause them to see an empty list for a second.

---

This change is 

[linear]

DROID-574 Missing relay list in location selection view

[Rawa]

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 183 at r1 (raw file):

                    }
                    is SelectLocationUiState.ShowData -> {
                        if (uiState.countries.isEmpty() && uiState.searchTerm.isNotEmpty()) {

I'm a bit confused about this one. Is it necessary? I mean if the countries list is Empty we should show the message no matter what right? Is there a case where the search term is empty and we don't have any countries? If so shouldn't it have a completely separate state?

[Rawa]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Pururun)

[Pururun]

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 183 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

I'm a bit confused about this one. Is it necessary? I mean if the countries list is Empty we should show the message no matter what right? Is there a case where the search term is empty and we don't have any countries? If so shouldn't it have a completely separate state?

This happens when the list we got from the daemon is empty. This currently shows a text that there is no search results for an empty term. But will move this check to the view model.

[Pururun]

Reviewable status: 2 of 9 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/SelectLocationScreen.kt line 183 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

This happens when the list we got from the daemon is empty. This currently shows a text that there is no search results for an empty term. But will move this check to the view model.

Done

[albin-mullvad]

Reviewed 2 of 5 files at r1, 4 of 7 files at r2, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

[albin-mullvad]

Dismissed @Rawa from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved