Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for changelog #5518

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Add checks for changelog #5518

merged 3 commits into from
Dec 1, 2023

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 29, 2023

Fix some incorrect changelog entries and add workflow for checking if the line length limit is respected.


This change is Reviewable

@dlon dlon force-pushed the changelog-improvements branch from 7c6d1a1 to e0d0639 Compare November 29, 2023 11:06
@dlon dlon requested review from raksooo and faern November 29, 2023 11:08
@dlon dlon force-pushed the changelog-improvements branch from dd8ea6a to b564bb1 Compare November 29, 2023 11:15
@dlon dlon marked this pull request as ready for review November 29, 2023 11:19
@dlon dlon force-pushed the changelog-improvements branch from 0ce58d6 to dcecfd6 Compare November 29, 2023 11:21
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the changelog-improvements branch from dcecfd6 to 2550a7d Compare December 1, 2023 15:26
@dlon dlon merged commit 960a0ed into main Dec 1, 2023
3 checks passed
@dlon dlon deleted the changelog-improvements branch December 1, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants